Fix handling of non-offline errors (#6968)

* Fix handling of non-offline errors * Update CHANGELOG.md
yarnpkg · Jan 30, 2019 · af91e7c · af91e7c
1 parent a640f49
commit af91e7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa
 
 ## Master
 
+- Fixes the error reporting for non-HTTP network errors (such as invalid certificates)
+
+  [#6968](https://github.com/yarnpkg/yarn/pull/6968) - [**Chih-Hsuan Yen**](https://github.com/yan12125)
+
 - Changes the location where the `--require ./.pnp.js` flag gets added into `NODE_OPTIONS`: now at the front (bis)
 
   [#6951](https://github.com/yarnpkg/yarn/pull/6951) - [**John-David Dalton**](https://twitter.com/jdalton)

diff --git a/src/util/request-manager.js b/src/util/request-manager.js
@@ -401,6 +401,8 @@ export default class RequestManager {
         if (!queueForRetry(this.reporter.lang('offlineRetrying'))) {
           reject(err);
         }
+      } else {
+        reject(err);
       }
     };