(WIP) yarn exits with an error when a dependency has no latest tag #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How did it happen? Private registry? Also, I think the fix would rather be the following (to avoid so that if there is no latest, then the dependency isn't marked as out of date rather than the opposite). What do you think? const isDepOld = ({current, latest, wanted}) =>
latest === 'exotic' || (semver.lt(current, wanted) || latest === undefined && semver.lt(current, latest)); |
|
Fixed with #6454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a dependency package has no latest tag the commands yarn upgrade and yarn upgrade-interactive will throw the following error:
An unexpected error occurred: "Invalid Version: undefined".
This is because in method getOutdatedPackages of the class PackageRequest latest is undefined when no latest tag is found and the call to semver.lt(current, latest) throws an error.
I simply checked if latest is undefined before the call to semver.lt(current, latest) .
fixes #5955
Test plan
I did not know how to write a test for this because i have found no public package that did not has a latest tag. Any advice would be great.