Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Darwin bash in bin/yarn #6568

Merged
merged 3 commits into from Oct 23, 2018
Merged

Support Darwin bash in bin/yarn #6568

merged 3 commits into from Oct 23, 2018

Commits on Oct 23, 2018

  1. Support Darwin bash in bin/yarn

    If the yarn binary is a symlink the `basepath` is not correctly resolved on OSX/Darwin.
    
    For example take the following structure:
    ```
    vendor/yarnpkg/yarn
    vendor/bin/yarn -> ../yarnpkg/yarn/bin/yarn
    ```
    
    And run yarn:
    ```
    $ yarn
    internal/modules/cjs/loader.js:582
        throw err;
        ^
    
    Error: Cannot find module '/Users/yarnpkg/yarn/bin/yarn.js'
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
        at Function.Module._load (internal/modules/cjs/loader.js:506:25)
        at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
        at startup (internal/bootstrap/node.js:285:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
    ```
    Since the symlink is not resolved the relative path in the symlink leads to the wrong path.
    
    This PR, fixes that issue.
    Hidde Boomsma committed Oct 23, 2018
    Copy the full SHA
    9772f6b View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    arcanis committed Oct 23, 2018
    Copy the full SHA
    0ffaa26 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2ef397b View commit details
    Browse the repository at this point in the history