Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): Remove rootModuleFolders variable which was not used #6846

Merged
merged 4 commits into from Feb 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa

## Master

- Removes `rootModuleFolders` (internal variable which wasn't used anywhere)

[#6846](https://github.com/yarnpkg/yarn/pull/6846) - [**Jeff Valore**](https://twitter.com/codingwithspike)

- Allows `global-folder` to be set in `.yarnrc` files

[#7056](https://github.com/yarnpkg/yarn/pull/7056) - [**Hsiao-nan Cheung**](https://github.com/niheaven)
Expand Down
1 change: 0 additions & 1 deletion src/cli/commands/config.js
Expand Up @@ -7,7 +7,6 @@ import buildSubCommands from './_build-sub-commands.js';

const CONFIG_KEYS = [
// 'reporter',
'rootModuleFolders',
'registryFolders',
'linkedModules',
// 'registries',
Expand Down
12 changes: 0 additions & 12 deletions src/config.js
Expand Up @@ -127,9 +127,6 @@ export default class Config {
//
linkedModules: Array<string>;

//
rootModuleFolders: Array<string>;

//
linkFolder: string;

Expand Down Expand Up @@ -317,10 +314,6 @@ export default class Config {
if (this.registryFolders.indexOf(registry.folder) === -1) {
this.registryFolders.push(registry.folder);
}
const rootModuleFolder = path.join(this.cwd, registry.folder);
if (this.rootModuleFolders.indexOf(rootModuleFolder) === -1) {
this.rootModuleFolders.push(rootModuleFolder);
}
}

if (this.modulesFolder) {
Expand Down Expand Up @@ -458,7 +451,6 @@ export default class Config {
}

_init(opts: ConfigOptions) {
this.rootModuleFolders = [];
this.registryFolders = [];
this.linkedModules = [];

Expand Down Expand Up @@ -499,10 +491,6 @@ export default class Config {
captureHar: !!opts.captureHar,
});

if (this.modulesFolder) {
this.rootModuleFolders.push(this.modulesFolder);
}

this.focus = !!opts.focus;
this.focusedWorkspaceName = '';

Expand Down