Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules-folder): Fix --modules-folder handling in several places. #6850

Merged
merged 6 commits into from Feb 28, 2019
Merged

fix(modules-folder): Fix --modules-folder handling in several places. #6850

merged 6 commits into from Feb 28, 2019

Commits on Dec 23, 2018

  1. fix(modules-folder): Fix --modules-folder handling in several places. 

    Fixes a few issues with the `--modules-folder` parameter.

The extraneous file check would always
also clean files from `node_modules`. This no longer happens, only the `--modules-folder` location
is checked.

The `yarn check` command used to always only check `node_modules`. Now it will check the
`--modules-folder` location instead.

When running a command or executing a lifecycle script, yarn
would build a `PATH` that included `node_modules/.bin` first, then add the `--modules-folder`'s
`/.bin` after, which would have led to the wrong binaries being executed.

fixes yarnpkg#5419 and fixes yarnpkg#6847
    @rally25rs
    rally25rs committed Dec 23, 2018
    Copy the full SHA
    5ca7db7 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @rally25rs
    rally25rs committed Dec 23, 2018
    Copy the full SHA
    8d906d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Merge branch 'master' into fix-extraneous-file-dir-5419

    @arcanis
    arcanis committed Jan 4, 2019
    Copy the full SHA
    337f445 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. fix --moduls-folder handling in bin and run commands

    @rally25rs
    rally25rs committed Jan 19, 2019
    Copy the full SHA
    6cc7c3e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Merge branch 'master' into fix-extraneous-file-dir-5419

    @arcanis
    arcanis committed Feb 28, 2019
    Copy the full SHA
    e188b0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-extraneous-file-dir-5419

    @arcanis
    arcanis committed Feb 28, 2019
    Copy the full SHA
    98df2f6 View commit details
    Browse the repository at this point in the history