Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dynamic require missing from webpack #6908

Merged
merged 3 commits into from Jan 14, 2019

Commits on Jan 11, 2019

  1. Fixing dynamic require missing from webpack

    When running `yarn pack` with a bundledDependency yarn was throwing
    an error: An unexpected error occurred: "Cannot find module \".\"".
    
    This was due to yarn's cli.js being transpiled to on line 110321:
    
    ```
    var thePackage = !(function webpackMissingModule() { var e = new Error("Cannot find module \".\""); e.code = 'MODULE_NOT_FOUND'; throw e; }());
    ```
    
    This line comes from https://github.com/stefanpenner/hash-for-dep/blob/e849d3e2f0350810716a0e504c84603362229570/lib/pkg.js#L20
    and is a dynamic require. This commit impements a fix for this based on the guidence from webpack/webpack#4175 (comment)
    
    This code was originally added with yarnpkg#5966
    thoov committed Jan 11, 2019
    Copy the full SHA
    5dd17da View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Update CHANGELOG.md

    arcanis committed Jan 14, 2019
    Copy the full SHA
    b8c4dd9 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5e2f516 View commit details
    Browse the repository at this point in the history