Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): Preserve none zero exit code #6926

Merged
merged 12 commits into from Mar 14, 2019
Merged

fix(run): Preserve none zero exit code #6926

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8bad42e
fix: preserve EXIT_CODE on close
zhigang1992 Jan 15, 2019
eb28bf0
test: - add test fixture
zhigang1992 Jan 15, 2019
65d2275
test: Move test to index folder
zhigang1992 Jan 15, 2019
977e65e
fix: Check for ProcessTermError
zhigang1992 Jan 15, 2019
b58b922
fix: Passing EXIT_CODE along when converting ProcessTermError
zhigang1992 Jan 15, 2019
8cc39fe
test: Use integration to to custom exit code
zhigang1992 Jan 15, 2019
fae8f68
fix: flow type check
zhigang1992 Jan 15, 2019
8992942
doc: Add Changelog
zhigang1992 Jan 15, 2019
b0f77da
refactor: Throw new ProcessTermError instead of using code differently
zhigang1992 Jan 24, 2019
0e4d41d
Merge branch 'master' into preserveExitCode
zhigang1992 Feb 8, 2019
1d12fe1
Update CHANGELOG.md
arcanis Mar 14, 2019
41c7259
Merge branch 'master' into preserveExitCode
arcanis Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions __tests__/fixtures/index/preserve-exit-code/exitWithCode78.js
View file
Open in desktop
@@ -0,0 +1 @@
process.exit(78);
7 changes: 7 additions & 0 deletions __tests__/fixtures/index/preserve-exit-code/package.json
View file
Open in desktop
@@ -0,0 +1,7 @@
{
"license": "MIT",
"scripts": {
"exitWithCode78": "node exitWithCode78.js"
}
}

5 changes: 5 additions & 0 deletions src/cli/index.js
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@ import {spawnp, forkp} from '../util/child.js';
import {version} from '../util/yarn-version.js';
import handleSignals from '../util/signal-handler.js';
import {boolify, boolifyWithDefault} from '../util/conversion.js';
import {ProcessTermError} from '../errors';

function findProjectRoot(base: string): string {
let prev = null;
Expand Down Expand Up @@ -583,6 +584,10 @@ export async function main({
reporter.info(command.getDocsInfo);
}

if (err instanceof ProcessTermError) {
return exit(err.EXIT_CODE || 1);
}

zhigang1992 marked this conversation as resolved.
Show resolved Hide resolved
return exit(1);
});
}
Expand Down