Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the prepare script of git dependencies even if NODE_ENV=production #7398

Merged
merged 4 commits into from Jul 24, 2019

Commits on Jul 13, 2019

  1. Run the prepare script of git dependencies even if NODE_ENV=production

    When installing a git dependency with the `NODE_ENV` environment variable set to `production`, yarn did not run the `prepare` lifecycle script, because `config.production` would default to true, and then `wrapLifecycle` would skip `prepare`:
    
    https://github.com/yarnpkg/yarn/blob/b6569538de69e0ccd201f0a33f1f5b52f2656f5b/src/cli/commands/install.js#L1202-L1207
    
    This is contrary to npm's behavior and the intent of `GitFetcher#fetchFromInstallAndPack`, which is to install the dependency with its devDependencies and run all the relevant lifecycle scripts (excluding `prepublish`), regardless of the configuration or environment settings of the parent install command.
    jfirebaugh committed Jul 13, 2019
    Copy the full SHA
    af6a68b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Update CHANGELOG.md

    jfirebaugh committed Jul 15, 2019
    Copy the full SHA
    e9c0706 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Update CHANGELOG.md

    arcanis committed Jul 24, 2019
    Copy the full SHA
    1f67674 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ae95972 View commit details
    Browse the repository at this point in the history