Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package path to json list #7462

Closed
wants to merge 17 commits into from
Closed

Add package path to json list #7462

wants to merge 17 commits into from

Conversation

krzysztof-pawlik-gat
Copy link

Summary

licensed tool for auditing licenses of packages needs to have a directory where a package is installed. Right now even for applications using yarn it will fallback to using npm to list dependencies, to fix that yarn needs to output a directory where files for each package are available.

Test plan

Tests have been updated, the only tricky part was that each test run will generate a different path (due to using /tmp and one-time directories in it), hence special care had to be taken to account for this.

@krzysztof-pawlik-gat
Copy link
Author

Tests will be failing due to expired certificates until #7457 is merged.

@rockwyc992
Copy link

@krzysztof-pawlik-gat #7457 has been merged, could you update CHANGELOG.md again?

@krzysztof-pawlik-gat
Copy link
Author

@rockwyc992 thanks! I've updated CHANGELOG.md and updated tests so they don't fail on Windows. All checks passing.

@krzysztof-pawlik-gat
Copy link
Author

Lint seems to be failing on master since #7512 got merged.

@krzysztof-pawlik-gat
Copy link
Author

Windows Node 10 failed with:

[3/5] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "d:\\a\\1\\s\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
yarn run v1.17.3
$ gulp build
[‌06:19:15‌] Local modules not found in d:\a\1\s‌
[‌06:19:15‌] Try running: npm install‌
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
bin:
total 12K
-rwxr-xr-x 1 VssAdministrator 197121 1.1K Sep 19 06:12 yarn
-rw-r--r-- 1 VssAdministrator 197121   34 Sep 19 06:12 yarn.cmd
-rwxr-xr-x 1 VssAdministrator 197121 1015 Sep 19 06:12 yarn.js
-rw-r--r-- 1 VssAdministrator 197121  175 Sep 19 06:12 yarn.ps1
-rwxr-xr-x 1 VssAdministrator 197121   42 Sep 19 06:12 yarnpkg
-rw-r--r-- 1 VssAdministrator 197121   30 Sep 19 06:12 yarnpkg.cmd
ls: cannot access 'lib': No such file or directory
##[error]Bash exited with code '2'.

The rest of tests/builds looks OK.

@sergey-alekseev
Copy link

Waiting for this as well to be able to use licensed for yarn.

@krzysztof-pawlik-gat krzysztof-pawlik-gat deleted the add-package-path-to-json-list branch October 27, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants