Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NPM_CONFIG_GLOBALCONFIG when present #7604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chaitan94
Copy link

@chaitan94 chaitan94 commented Oct 6, 2019

Summary

This pull request is to address issue #5543
I hope it helps! Any feedback to improve the code is welcome.

Also, I am not sure if this helps resolve #4451 as well.

Test plan

  • Added an appropriate unit test and tested using node_modules/jest/bin/jest.js -i __tests__/registries/npm-registry.js
  • Manually tested with the following steps:
    1. Created a file /tmp/customrc with the content ANSWER=42
    2. Built the yarn binary yarn build
    3. Ran NPM_CONFIG_GLOBALCONFIG=/tmp/customrc ./bin/yarn config get ANSWER
    4. Verified that the output is 42 as expected.

@phgn0
Copy link

phgn0 commented May 29, 2020

Can we please get this PR reviewed? It's solving a very real config bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn does not honor authentication settings in .npmrc
2 participants