Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make running with Plug'n Play possible on node 13 #7650

Merged
merged 6 commits into from Nov 7, 2019
Merged

make running with Plug'n Play possible on node 13 #7650

merged 6 commits into from Nov 7, 2019

Commits on Oct 27, 2019

  1. ci(circleci): prevent timeout on circle-ci macos node10 build

    The circle ci job for macOS on node 10 currently fails because it takes too long
    (both PR's #7649 and #7650 don't green because of that). A big chunk of the time
    is taken by updating homebrew - which in this macOS (the one connected to xcode 9
    => macOS 10.12) does not contain node 10 by default.
    
    This change:
    - sets the required xcode version to 11.0 -> this gets us a more up to date macOS
      version (except for node 6, which isn't available in the homebrew associated
      with xcode 11)
    - removes the brew update from the macOS node 10 job
    sverweij committed Oct 27, 2019
    Copy the full SHA
    e0b807d View commit details
    Browse the repository at this point in the history
  2. fix(generate-pnp-map-api.tpl.js): make running with Plug'n Play possi…

    …ble on node 13
    
    On node 13 Module._findPath (which the setup() of this module redefines) also gets
    called with null for the path parameter (by lib/internal/bootstrap/pre_execution.js
    in the (new) function resolveMainPath).
    
    This fix ensures the patched _findPath also handles that situation.
    sverweij committed Oct 27, 2019
    Copy the full SHA
    a029fc3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    b1e585a View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1d20f23 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    ff9bbab View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2019

  1. Copy the full SHA
    609c1bb View commit details
    Browse the repository at this point in the history