ci(circleci): prevent timeout on circle-ci macos node10 build #7651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
The circle ci job for macOS on node 10 currently fails because it takes too long (both PR's #7649 and #7650 don't green because of that). A big chunk of the time is taken by updating homebrew - which in this macOS (the one connected to xcode 9 => macOS 10.12) does not contain node 10 by default. This change: - sets the required xcode version to 11.0 -> this gets us a more up to date macOS version (except for node 6, which isn't available in the homebrew associated with xcode 11) - removes the brew update from the macOS node 10 job
sverweij
changed the title
|
Sounds good, we don't care about Node 6 anymore 🙂 |
arcanis
pushed a commit
that referenced
this pull request
Nov 22, 2019
The circle ci job for macOS on node 10 currently fails because it takes too long (both PR's #7649 and #7650 don't green because of that). A big chunk of the time is taken by updating homebrew - which in this macOS (the one connected to xcode 9 => macOS 10.12) does not contain node 10 by default. This change: - sets the required xcode version to 11.0 -> this gets us a more up to date macOS version (except for node 6, which isn't available in the homebrew associated with xcode 11) - removes the brew update from the macOS node 10 job
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
…g#7651) The circle ci job for macOS on node 10 currently fails because it takes too long (both PR's yarnpkg#7649 and yarnpkg#7650 don't green because of that). A big chunk of the time is taken by updating homebrew - which in this macOS (the one connected to xcode 9 => macOS 10.12) does not contain node 10 by default. This change: - sets the required xcode version to 11.0 -> this gets us a more up to date macOS version (except for node 6, which isn't available in the homebrew associated with xcode 11) - removes the brew update from the macOS node 10 job
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
…g#7651) The circle ci job for macOS on node 10 currently fails because it takes too long (both PR's yarnpkg#7649 and yarnpkg#7650 don't green because of that). A big chunk of the time is taken by updating homebrew - which in this macOS (the one connected to xcode 9 => macOS 10.12) does not contain node 10 by default. This change: - sets the required xcode version to 11.0 -> this gets us a more up to date macOS version (except for node 6, which isn't available in the homebrew associated with xcode 11) - removes the brew update from the macOS node 10 job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
brew updatefrom the macOS node 10 jobAs a bonus the CI for node 10 on circleci/ macOS got 15 - 20 minutes faster.
Why, though?
The circle ci job for macOS on node 10 currently fails because it takes too long (both PR's #7649 and #7650 don't green because of that). Cause: the job uses a big chunk of time updating homebrew (up to ~20min). Which is necessary because the version of macOS (the one connected to xcode 9 => macOS 10.12) does not contain node 10 by default.
Using a more recent version of macOS does away with this necessity for node 8 and 10. Putting node 6 on this would've been nice, but it is not available in homebrew on the macOS images that have xcode 11 on them
Test plan
Notes
I've rebased make running with Plug'n Play possible on node 13 #7650 on the branch underlying this PR - so if that one might get merged first this PR can be closed unmerged.
When running the xcode 9 image, the system warns it's outdated and unsupported, as is the version of macOS. If node 6 still needs to be tested on macOS via circleci it might be worth considering a different installation strategy (e.g. using nvm in stead of homebrew?).