Handle GitHub Package Registry URLs #7664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When yarn-offline-mirror-pruning is set to true, mirrored tarball filename of package must be resolved from download URL to scoped tarball filename.
|
Hey! Thanks for the diff! Can you describe in more details the bug and circumstances of the bug? Without knowing the context I'm not entirely sure what it fixes. Thanks 😃 |
The change is similar to #7499 to fix offline mirror filename but with GitHub package registry. |
|
Is there a workaround for this issue? Or any plan to merge this change in? I'm experiencing the same issue of yarn not pulling down the tarball into the offline mirror if it's in a private GitHub package repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix tarball name resolver to handle GitHub Package Registry (currently still in beta) to match what I've experienced using private packages via beta program signup.
Because basename part of the urls do not match scoped tarball filenames, also offline mirror pruning needs to match the filename from url.
This is not very clean code, but for me it looks like handling offline mirror pruning correctly the codebase needs some refactoring to match tarball filenames in common way usable both for tarball fetcher and offline mirror pruning.
Test plan
Added tarball fetcher test similar to other private package registries have. For offline mirror pruning I did not find suitable template for adding new test.