New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workspaces): Pass args following "--" when running workspace scripts #7786
Merged
arcanis
merged 4 commits into
yarnpkg:master
from
rally25rs:fix-workspace-arg-passing-7776
Jan 22, 2020
Merged
fix(workspaces): Pass args following "--" when running workspace scripts #7786
arcanis
merged 4 commits into
yarnpkg:master
from
rally25rs:fix-workspace-arg-passing-7776
Jan 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776
… running a workspace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776
@arcanis do you know what the errors on circleci are all about?
isn't very helpful... 😕 |
My guess is that |
Ah, yeah, thanks for that help. The old logic had
but in my changes I had applied having 1 |
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
…pts (yarnpkg#7786) * fix(workspaces): Passes arguments follwing "--" when running a workspace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776 * fix spelling in changelog * fix(workspaces): fix(workspaces): Passes arguments follwing "--" when running a workspace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776 * don't ignore a parameter when running 'node' command
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
…pts (yarnpkg#7786) * fix(workspaces): Passes arguments follwing "--" when running a workspace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776 * fix spelling in changelog * fix(workspaces): fix(workspaces): Passes arguments follwing "--" when running a workspace script Passes arguments follwing `--` when running a workspace script (`yarn workspace pkg run command -- arg`). Previously these parameters were being trimmed off and ignored. fixes yarnpkg#7776 * don't ignore a parameter when running 'node' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7776
Summary
Arguments following a
--
when runningyarn workspaces run ...
andyarn workspace package run ...
were not being forwarded to the scripts.Removed the
commander.originalArgs
nonsense that I introduced in a previous PR, and changed theworkspace
andworkspaces
commands to useargs
as already passed instead.The
yarn run
command usedargs
so it makes sense forworkspace run
to useargs
too.I had to modify
src/index.js
's check for commands that should forward args and addworkspace
andworkspaces
to it. Again this is in-line with what already happened for the normalyarn run
command.As an added bonus, the normal
scripts don't require "--"
warning thatyarn run
normally prints, is now printed forworkspace
commands (it was not printed before this PR).Test plan
Added unit tests to
__tests__/index.js
A manual test can be performed by setting up a basic workspace project:
package.json
packages/pkg1/package.json
packages/pkg1/start.sh
then run the yarn commands
The output from each should be
ARGS: one two three