Make CVE-2020-8131 mitigation opt-in #8008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After reading through the HackerOne report and corresponding PR, it looks like this mitigation was intended to prevent arbitrary file writes when
--ignore-scriptsis passed. However, this mitigation was used even when--ignore-scriptsis not enabled and can break the installation of packages that have hard/symbolic links inside their own directories (see #7890). This PR enables the behavior only when--ignore-scriptsis passed.Fixes #7890
Test plan
Tested with packages mentioned in #7890 (e.g.
lz4)