Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass a bower object in options #125

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

jonnyzzz
Copy link

grunt-bower-task has fixed dependency on bower. This could be as issue if the selected bower contains back or feature lack.

In the patch I add a parameter bower to the options. The parameter is optional. When defined it allows to specify any bower that is required for the outer grunt build. It is easy to use, since one should only add require('bower') into theirs script.

@yatskevich
Copy link
Owner

@jonnyzzz Thank you for the contribution. It seems this feature may open a window for a further confusion, so people may start using a version of bower which is not supported by the plugin. So I'd prefer to keep bower's version fixed.

If you have any ideas on how to provide flexibility of custom bower version and at the same time maintain safety net for the users, please share with us.

@jonnyzzz
Copy link
Author

The main issue I tried to solve was to get the way to update the bower in
case of a bug in it. That was the situation where the fix was required asap.

I got your concerns. Still the task may warn if the version of bower is too
new and give it a try. The thing is that it gives us the workaround for the
bower version to use. Otherwise the task code is an extea point of failure
because we must wait for the fix from you too.

What is for the usecase where one has custom build of bower?
On Jul 20, 2014 3:14 PM, "Ivan Yatskevich" notifications@github.com wrote:

@jonnyzzz https://github.com/jonnyzzz Thank you for the contribution.
It seems this feature may open a window for a further confusion, so people
may start using a version of bower which is not supported by the plugin. So
I'd prefer to keep bower's version fixed.

If you have any ideas on how to provide flexibility of custom bower
version and at the same time maintain safety net for the users, please
share with us.


Reply to this email directly or view it on GitHub
#125 (comment)
.

@PallasDoesCode
Copy link
Collaborator

@jonnyzzz I believe what @yatskevich was saying is that your PR allows others to use a custom build of bower. He'd prefer not to allow that and stick with the official releases.

With that in mind If you are wanting to use a different version of Bower than what is being used by the grunt-bower-task package, then you can always use npm-shrinkwrap and specify which version you want to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants