Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to docusaurus v3 #15

Merged
merged 8 commits into from Nov 1, 2023
Merged

feat: upgrade to docusaurus v3 #15

merged 8 commits into from Nov 1, 2023

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Nov 1, 2023

https://docusaurus.io/blog/releases/3.0

Breaking changes here are Node 16 to Node 18, MDX v1 to v3, and prism-react-renderer@v2. We don't have to but I'm also working on switching to TypeScript where possible.

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

Looks like Prettier is pretty far behind in terms of MDX support (prettier/prettier#12209), let's see if there are any formatting issues but we might have to put this off.

@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

Currently only https://github.com/yazi-rs/yazi-rs.github.io/blob/main/usage/configuration/overview.mdx is in MDX format, but in fact it doesn't use any MDX features, I think it can be converted to Markdown.

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

There's also https://github.com/yazi-rs/yazi-rs.github.io/blob/main/usage/quick-start.md?plain=1#L134-L182 though.

EDIT: I'll disable MDX and I think the formatting is fine enough for that one section I just linked to.

@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

Oh yes. I agree to disable it first.

BTW I found a new markdown formatter https://github.com/remarkjs/remark. I'll add it to my nvim configuration and give it a try later to see if it works normally.

@uncenter

This comment was marked as resolved.

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

I don't see any remaining issues visually. Can you take a look through and let me know if there are any other issues?

@uncenter uncenter marked this pull request as ready for review November 1, 2023 15:33
@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

I recreated the site with Docusaurus CLI & --typescript and moved everything back in. I also thought we could switch from "Usage" and /usage/ to "Docs" and /docs/.

Good point! Previously the repo was 'yazi-rs/docs', it corresponded to https://yazi-rs.github.io/docs/. If its name were 'docs', it would have been https://yazi-rs.github.io/docs/docs/.

But now this issue no longer exists, and 'docs' is even shorter than 'usage', I like it! 😍

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

I also thought we could rename "Showcase" to "Features" but I'll do that in a separate PR after this merges.

cspell.json Show resolved Hide resolved
docs/quick-start.md Outdated Show resolved Hide resolved
@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

I also thought we could rename "Showcase" to "Features" but I'll do that in a separate PR after this merges.

This page will include some user created plugins (once the plugin system is available), seems "features" is not quite accurate - it's generally provided by the official imo

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

I also thought we could rename "Showcase" to "Features" but I'll do that in a separate PR after this merges.

This page will include some user created plugins (once the plugin system is available), seems "features" is not quite accurate - it's generally provided by the official imo

That's why I think we should have a separate features and showcase page. For features built in to Yazi, those go on Features. For custom plugins from the community that we want to showcase, we put those in Showcase.

@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

That's why I think we should have a separate features and showcase page. For features built in to Yazi, those go on Features. For custom plugins from the community that we want to showcase, we put those in Showcase.

Sounds good, I hadn't thought about separating them ;)

@sxyazi
Copy link
Member

sxyazi commented Nov 1, 2023

Looks great to me!

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

Awesome. I'll give you the honor of merging!

@sxyazi sxyazi merged commit 8b80364 into main Nov 1, 2023
@sxyazi sxyazi deleted the docusaurus-v3 branch November 1, 2023 16:39
@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

FYI @sxyazi I think Prettier works just fine for the MDX we have so far. I don't think we need to switch to Remark.

@uncenter
Copy link
Member Author

uncenter commented Nov 1, 2023

And you've probably already seen this but: davidmh/cspell.nvim#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants