Merge pull request #11 from yceruto/amount_mapping

Persist Money amount field as integer
yceruto · Jan 30, 2023 · 5fad0ce · 5fad0ce
2 parents 68666d2 + 35ad706
commit 5fad0ce
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/config/doctrine/mapping/Money.orm.xml b/config/doctrine/mapping/Money.orm.xml
@@ -5,7 +5,7 @@
                                       https://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd">
 
     <embeddable name="Money\Money">
-        <field name="amount" />
+        <field name="amount" type="integer" />
         <embedded name="currency" class="Money\Currency" use-column-prefix="false" />
     </embeddable>
 </doctrine-mapping>
diff --git a/tests/DependencyInjection/MoneyExtensionTest.php b/tests/DependencyInjection/MoneyExtensionTest.php
@@ -149,7 +149,7 @@ public function testMoneyDoctrineMapping(): void
         self::assertTrue($metadata->isEmbeddedClass);
         self::assertSame(Money::class, $metadata->getName());
         self::assertSame(['amount', 'currency.code'], $metadata->getFieldNames());
-        self::assertSame('string', $metadata->getTypeOfField('amount'));
+        self::assertSame('integer', $metadata->getTypeOfField('amount'));
         self::assertSame('string', $metadata->getTypeOfField('currency.code'));
         self::assertCount(1, $metadata->embeddedClasses);
         self::assertSame(Currency::class, $metadata->embeddedClasses['currency']['class']);

diff --git a/tests/Model/MoneyDtoTest.php b/tests/Model/MoneyDtoTest.php
@@ -13,7 +13,6 @@
 
 namespace Yceruto\MoneyBundle\Tests\Model;
 
-use AssertionError;
 use Money\Money;
 use PHPUnit\Framework\TestCase;
 use Throwable;