Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getter and setter metric #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MishanyaHSE
Copy link

Our team added metric to research complexity of code with getters and setters

@yegor256
Copy link
Owner

yegor256 commented Feb 1, 2024

@MishanyaHSE looks good, thanks for your contribution. A few suggestions before we merge this PR: 1) don't use Russian in comments, only English please. 2) add a unit test, similar to the one that exists for ast.py, 3) run make in order to see whether your changes didn't break anything.

@yegor256
Copy link
Owner

@MishanyaHSE any progress here?

@padjal
Copy link
Contributor

padjal commented Apr 22, 2024

@yegor256 This PR Is duplicated with #267. You can close it.

@yegor256 yegor256 closed this Apr 27, 2024
@yegor256 yegor256 reopened this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants