New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue Number: 24 - Git Siblings #208
Conversation
@tanmaysharma2001 looks like a very good start, thanks! Now, please, try to run Also, if it's a "step", we should name it like all other steps: |
Hi @yegor256 thanks a lot. I have fixed one the 1 test where my script was failing. Although, i had few problems with installing make clean install, which includes installing dependencies. I'm working on that. Meanwhile I request you to approve the PR so that it can run the tests again. Also i have written the unit test for the script too. Also I wanted to ask about the step number. I didn't quite understand where should i name it cause other steps are named according to their purposes. For example: aggregate-join.sh. Sorry if i misunderstood anything. Thanks. |
@tanmaysharma2001 this should be a metric, not a "step". Put your file into the |
Done @yegor256 Thanks a lot. |
repo=$1 | ||
|
||
# List all Java files in the repo history | ||
git -C "${repo}/" log --name-only --pretty=format: | grep '\.java$' | sort | uniq > "${repo}/all_java_files.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanmaysharma2001 this script will be called for each .java
file in each repository. I believe, it will take a lot of time, if we rebuild this .txt
file on each cycle. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, i will try to find a workaround.
} >> "${repo}/siblings_count.txt" | ||
done < "${repo}/all_java_files.txt" | ||
|
||
echo "Analysis complete. Check siblings_count.txt for results." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanmaysharma2001 check how other files in the metrics/
directory work. They are supposed to output their data in a certain format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood.
Fix for the Issue Number 24 in the Cam Repo.
Problem Description:
For each .java class, let's count the number of other .java classes which it was updated together with, in the Git history.
Solution Description: