New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
float.sh must print exactly three digits after the dot #241
Conversation
@LaithAlebrahim try to run |
Actually there is some failed test but not related in my code they are in different folder: because when I run UPD: I've improved the checking here to be more accurate (ebe8071) UPD2: Here is example of error which we need to modify: |
@yegor256 I got the issue is that in the new float.sh we print .000 for all numbers as you required in task so we just need to modiffy other tests I can work on it and handle or u can make a ticket for it so I can submit it . |
@LaithAlebrahim you have to fix all tests in this branch, otherwise we won't be able to merge it |
compose-dev.yaml
Outdated
@@ -0,0 +1,12 @@ | |||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaithAlebrahim this file seems to not belong to this repo :)
I'll delete sorry this because am running the project in docker dev environment , The project did not run rather than on this env. This failed test from the original master branch in your repo. and same error on mine now so I guess we are on same page now. And the required from task is done cuz the float-test it passed |
Could you please check my last comment and let me know if there is some thing need to be done .Thanks @yegor256 |
@LaithAlebrahim you can run tests in Docker (if you can't install all dependencies locally):
However, I suggest you try again (a lot of changes have been made recently):
|
No description provided.