-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created an AllCaps format test (Issue #237) #261
Merged
Merged
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8cb15f0
Created an AllCaps format test (based on measure-file.sh to run all m…
MoromugHSE 627d9e3
Merge branch 'yegor256:master' into test-allcaps
MoromugHSE bee7dbb
Updated test-allcaps.sh to current number of collectable metrics.
MoromugHSE 8b370ca
Merge remote-tracking branch 'origin/test-allcaps' into test-allcaps
MoromugHSE 58af847
Replaced "expected" literal with expression and cleaned the code acco…
MoromugHSE 531a3ad
Cleaned the code according to linter demands once more.
MoromugHSE 47250cb
Changed all metric names to AllCaps, so now the tests don't fail!
MoromugHSE d47d460
Trying to fix build troubles.
MoromugHSE 47cf79c
Trying to fix build troubles.
MoromugHSE b069e64
I don't even know anymore...
MoromugHSE d2b6a55
Checking possibilities.
MoromugHSE 522a1e0
Removed double check of some files.
MoromugHSE 36fc351
Integration test is somewhy impossible -- I see no reason for it to f…
MoromugHSE 668c204
Temporary removed test-allcaps.sh
MoromugHSE 2834818
Returning test-allcaps.sh -- should be executable now
MoromugHSE aaf7cde
Allowing jPeek to use "-cvc" suffix in its metrics (until further pro…
MoromugHSE 81265dd
Now git sees test-allcaps.sh as executable
MoromugHSE 8b94506
Merge pull request #5 from MoromugHSE/master
MoromugHSE File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
#!/usr/bin/env bash | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
set -e | ||
set -o pipefail | ||
|
||
temp=$1 | ||
stdout=$2 | ||
|
||
{ | ||
java="${temp}/Foo(xls;)';ого привет '\".java" | ||
cat > "${java}" <<EOT | ||
class Foo extends Boo implements Bar { | ||
// This is static | ||
private static int X = 1; | ||
private String z; | ||
|
||
Foo(String zz) { | ||
this.z = zz; | ||
} | ||
private final boolean boom() { return true; } | ||
} | ||
EOT | ||
msg=$("${LOCAL}/steps/measure-file.sh" "${java}" "${temp}/m1") | ||
set -x | ||
all=$(find "${temp}" -name 'm1.*' -type f -exec basename {} \; | sort) | ||
expected=52 | ||
actual=$(echo "${all}" | grep -E 'm1.([A-Z][A-Za-z]*)+$' | wc -l | xargs) | ||
if [ ! "${actual}" = "${expected}" ]; then | ||
echo "Exactly ${expected} metrics were expected to be named in AllCaps format, but ${actual} actually were" | ||
exit 1 | ||
fi | ||
set +x | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 All metrics are correctly named in AllCaps format" | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoromugHSE looks like a typo. The
expected
should be counted fromall