-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a unique names test (Issue #234) #262
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ab8cd3a
Created a metric name uniqueness test (based on measure-file.sh to ru…
MoromugHSE 90e3e45
Replaced "expected" literal with expression and cleaned the code acco…
MoromugHSE d64b2d7
Now I'm 100% sure. This build even works in docker. I can't imagine i…
MoromugHSE 6b1c579
I've removed redundant target from non-docker runs. Should work?
MoromugHSE fe6897a
Desperate times -- trying to make test-unique.sh executable
MoromugHSE fe62ee9
Temporary removed test-unique.sh
MoromugHSE b94f093
Recreated test-unique.sh -- hopely executable now
MoromugHSE b4e1d55
Now git sees test-unique.sh as executable
MoromugHSE File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
#!/usr/bin/env bash | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
set -e | ||
set -o pipefail | ||
|
||
temp=$1 | ||
stdout=$2 | ||
|
||
{ | ||
java="${temp}/Foo(xls;)';aга привет '\".java" | ||
cat > "${java}" <<EOT | ||
class Foo extends Boo implements Bar { | ||
// This is static | ||
private static int X = 1; | ||
private String z; | ||
|
||
Foo(String zz) { | ||
this.z = zz; | ||
} | ||
private final boolean boom() { return true; } | ||
} | ||
EOT | ||
$("${LOCAL}/steps/measure-file.sh" "${java}" "${temp}/m1") | ||
set -x | ||
all=$(find "${temp}" -name 'm1.*' -type f -exec basename {} \; | sort) | ||
expected=52 | ||
actual=$(echo "${all}" | uniq | wc -l | xargs) | ||
if [ ! "${actual}" = "${expected}" ]; then | ||
echo "Exactly ${expected} unique metric names were expected, but ${actual} were actually found" | ||
exit 1 | ||
fi | ||
set +x | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 All provided metrics are named uniquely" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoromugHSE it's a typo, I believe? The
expected
should be counted, not be a constant?