Implemented test for irc feature #279
Conversation
|
@yegor256 please, check this test out |
|
@zaqbez39me looks good, but |
|
@yegor256 check it out, please. I suppose, it is ready to be merged |
tests/metrics/test-irc.sh
Outdated
| cd "${tmp}" | ||
| mkdir -p "${LOCAL}/${temp}" | ||
| touch "${LOCAL}/${temp}/file.java" | ||
| "${LOCAL}/metrics/irc.sh" "${LOCAL}/${temp}/file.java" "${LOCAL}/${temp}/stdout" |
tests/metrics/test-irc.sh
Outdated
| git config user.email 'foo@example.com' | ||
| git config user.name 'Foo' | ||
| file1="one.java" | ||
| "${LOCAL}/metrics/irc.sh" "./${file1}" "t0" |
tests/metrics/test-irc.sh
Outdated
| file1="one.java" | ||
| touch "${file1}" | ||
| "${LOCAL}/metrics/irc.sh" "./${file1}" "t0" | ||
| grep "No commits yet in repo" "t0" # There are no commits in repo with given file |
There was a problem hiding this comment.
@zaqbez39me the output is wrong, should be IRC 0 (or something similar)
|
@yegor256 please check it out. I changed the expected behaviour after your review. |
metrics/irc.sh
Outdated
|
|
||
| output=$(realpath "$2") | ||
|
|
||
| # TODO: #279 REPLACE WITH ACTUAL METRIC CODE |
There was a problem hiding this comment.
@zaqbez39me better remove this TODO, since it will trigger the creation of a new issue in the backlog -- we don't want TWO issues to originate from this pull requests. just one is enough.
There was a problem hiding this comment.
@yegor256 removed it
|
@yegor256 check it out, removed multiple TODOs referencing one PR |
|
@zaqbez39me thanks!@ |
Test for Impact Ratio by Commits (IRC) feature in #226