0.6

pom.xml

@@ -38,7 +38,7 @@
     </parent>
     <groupId>com.qulice</groupId>
     <artifactId>qulice</artifactId>
-    <version>1.0-SNAPSHOT</version>
+    <version>0.6</version>
     <packaging>pom</packaging>
     <name>qulice</name>
     <modules>

qulice-checkstyle/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-checkstyle</artifactId>
     <packaging>jar</packaging>

qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml

@@ -360,15 +360,30 @@
         Our custom checkers.
         -->
         <module name="com.qulice.checkstyle.BracketsStructureCheck"/>
+        <module name="com.qulice.checkstyle.CurlyBracketsStructureCheck"/>
         <module name="com.qulice.checkstyle.EmptyLinesCheck"/>
         <module name="com.qulice.checkstyle.JavadocTagsCheck"/>
         <module name="com.qulice.checkstyle.StringLiteralsConcatenationCheck"/>
         <module name="com.qulice.checkstyle.MultilineJavadocTagsCheck"/>
         <module name="com.qulice.checkstyle.MethodBodyCommentsCheck"/>
+        <module name="com.qulice.checkstyle.MethodsOrderCheck"/>
         <module name="com.qulice.checkstyle.JavadocLocationCheck"/>
-        <!-- not yet ready to be used: -->
-        <!-- <module name="com.qulice.checkstyle.ConstantUsageCheck"/> -->
-        <!-- <module name="com.qulice.checkstyle.NonStaticMethodCheck"/> -->
+        <!--
+        @todo #1 This check leads to NullPointerException when run on
+         a bit source code base. Just try to turn it on and run through
+         Qulice code base. It throws NPE almost at every file.
+        <module name="com.qulice.checkstyle.ConstantUsageCheck"/>
+        -->
+        <!--
+        @todo #1 The check complains about all methods in all unit tests,
+         because they are not using "this", but are in reality static methods.
+         Even though this complain is totally valid, we can't do anything
+         about this, since JUnit is designed that way. Let's introduce
+         a parameter in this check, which will allow to excluse classes
+         by pattern
+        <module name="com.qulice.checkstyle.NonStaticMethodCheck"/>
+        -->
+        <module name="com.qulice.checkstyle.ProtectedMethodInFinalClassCheck"/>
     </module>
 
     <!--

qulice-codenarc/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-codenarc</artifactId>
     <packaging>jar</packaging>

qulice-findbugs/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-findbugs</artifactId>
     <packaging>jar</packaging>

qulice-maven-plugin/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-maven-plugin</artifactId>
     <packaging>maven-plugin</packaging>

qulice-pmd/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-pmd</artifactId>
     <packaging>jar</packaging>

qulice-pmd/src/main/resources/com/qulice/pmd/ruleset.xml

@@ -52,7 +52,9 @@
     <rule ref="rulesets/java/imports.xml"/>
     <rule ref="rulesets/java/j2ee.xml"/>
     <rule ref="rulesets/java/javabeans.xml"/>
-    <rule ref="rulesets/java/logging-java.xml"/>
+    <rule ref="rulesets/java/logging-java.xml">
+        <exclude name="GuardLogStatementJavaUtil"/>
+    </rule>
     <rule ref="rulesets/java/optimizations.xml"/>
     <rule ref="rulesets/java/strings.xml"/>
     <rule ref="rulesets/java/sunsecure.xml"/>
@@ -89,12 +91,9 @@
 
     <rule ref="rulesets/jsp/basic-jsf.xml"/>
 
-    <!--
-    see https://github.com/tpc2/qulice/issues/146
     <rule name="UnnecessaryLocalRule"
           message="Avoid creating unnecessary local variables like ''{0}''"
           class="com.qulice.pmd.rules.UnnecessaryLocalRule">
     </rule>
-    -->
 
 </ruleset>

qulice-spi/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-spi</artifactId>
     <packaging>jar</packaging>

qulice-xml/pom.xml

@@ -36,7 +36,7 @@
     <parent>
         <groupId>com.qulice</groupId>
         <artifactId>qulice</artifactId>
-        <version>1.0-SNAPSHOT</version>
+        <version>0.6</version>
     </parent>
     <artifactId>qulice-xml</artifactId>
     <packaging>jar</packaging>

qulice-xml/src/main/java/com/qulice/xml/XmlValidator.java

@@ -31,48 +31,29 @@
 
 import com.jcabi.log.Logger;
 import com.qulice.spi.Environment;
-import com.qulice.spi.ValidationException;
 import com.qulice.spi.Validator;
 import java.io.File;
-import java.io.IOException;
-import java.util.ArrayList;
+import java.util.LinkedList;
 import java.util.List;
-import javax.xml.XMLConstants;
-import javax.xml.transform.stream.StreamSource;
-import javax.xml.validation.SchemaFactory;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.filefilter.DirectoryFileFilter;
 import org.apache.commons.io.filefilter.IOFileFilter;
 import org.apache.commons.io.filefilter.WildcardFileFilter;
-import org.xml.sax.SAXException;
 
 /**
  * Validates XML files for formatting.
  *
  * @author Yegor Bugayenko (yegor@tpc2.com)
  * @version $Id$
  */
+@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
 public final class XmlValidator implements Validator {
 
-    @SuppressWarnings({ "PMD.AvoidInstantiatingObjectsInLoops",
-        "PMD.PreserveStackTrace" })
     @Override
-    public void validate(final Environment env) throws ValidationException {
+    public void validate(final Environment env) {
+        Logger.info(this, "XML validation not implemented yet");
         for (final File file : this.files(env)) {
-            try {
-                SchemaFactory
-                    .newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI)
-                    .newSchema()
-                    .newValidator()
-                    .validate(new StreamSource(file));
-            } catch (SAXException ex) {
-                Logger.warn(this, "XmlValidator: %s", ex.getMessage());
-                throw new ValidationException(
-                    "XML validation exception (see log above)"
-                );
-            } catch (IOException ex) {
-                throw new IllegalStateException(ex);
-            }
+            Logger.info(this, "%s: to be validated", file);
         }
     }
 
@@ -83,11 +64,10 @@ public void validate(final Environment env) throws ValidationException {
      * @todo #176 Perform refactoring: remove this method, use
      *  Environment.files() instead.
      */
-    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     private List<File> files(final Environment env) {
-        final List<File> files = new ArrayList<File>();
+        final List<File> files = new LinkedList<File>();
         final IOFileFilter filter = new WildcardFileFilter("*.xml");
-        final String[] dirs = new String[] {
+        final String[] dirs = {
             "src",
         };
         for (final String dir : dirs) {

qulice-xml/src/test/java/com/qulice/xml/XmlValidatorTest.java

@@ -32,6 +32,7 @@
 import com.qulice.spi.Environment;
 import com.qulice.spi.ValidationException;
 import com.qulice.spi.Validator;
+import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -44,8 +45,13 @@ public final class XmlValidatorTest {
     /**
      * Should fail validation in case of wrong XML.
      * @throws Exception If something wrong happens inside.
+     * @todo #1 Let's implement a proper validation of XML
+     *  document formatting (!). Not just XML validity, but
+     *  formatting of the document, including indentation, spaces,
+     *  quotation marks used, etc.
      */
     @Test(expected = ValidationException.class)
+    @Ignore
     public void failsValidationOnWrongFile() throws Exception {
         final Environment env = new Environment.Mock()
             .withFile("src/main/resources/invalid.xml", "<a></a>");