Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegexpSinglelineCheck applies to *.png, *.js, *.css files within the standalone application #1055

Closed
dgroup opened this issue Jun 23, 2019 · 6 comments

Comments

@dgroup
Copy link
Contributor

dgroup commented Jun 23, 2019

....
[INFO] --- qulice-maven-plugin:0.18.19:check (apply-qulice-validations) @ app ---
[INFO] Checkstyle: app/src/main/resources/css/images/arrow_undo.png[7]: Line has trailing spaces. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/images/row-over-bg.gif[1]: Line has trailing spaces. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/images/row-over-bg.gif[4]: Line has trailing spaces. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/images/ajax-loader-small.gif[1]: Line has trailing spaces. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/images/ajax-loader-small.gif[3]: Line has trailing spaces. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/images/ajax-loader-small.gif[6]: Line has trailing spaces. (RegexpSinglelineCheck)
...
[INFO] Checkstyle: app/src/main/resources/css/d8028d77a21b72097d41c29284210d534de247fe.cache.css[204]: This kind of comment is not allowed. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/d8028d77a21b72097d41c29284210d534de247fe.cache.css[213]: This kind of comment is not allowed. (RegexpSinglelineCheck)
[INFO] Checkstyle: app/src/main/resources/css/d8028d77a21b72097d41c29284210d534de247fe.cache.css[235]: This kind of comment is not allowed. (RegexpSinglelineCheck)

https://checkstyle.sourceforge.io/config_regexp.html#RegexpSingleline

@0crat
Copy link
Collaborator

0crat commented Jun 23, 2019

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jun 23, 2019

@dgroup/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@dgroup dgroup changed the title RegexpSinglelineCheck applies to *.png, *.js, *.css files within the console application RegexpSinglelineCheck applies to *.png, *.js, *.css files within the standalone application Jun 23, 2019
@dgroup
Copy link
Contributor Author

dgroup commented Aug 20, 2019

@krzyk up

@dgroup
Copy link
Contributor Author

dgroup commented May 11, 2020

@paulodamaso @krzyk Is there any chance to fix this issue?
Today I found that this rule is applying to *.class files which are available in /src/test/resources.
I'm writing a lib that manipulates with bytecode and can't use qulice due to this rule :(.

I don't want to invent different hacks in order to avoid this violation... :(

@dgroup
Copy link
Contributor Author

dgroup commented May 11, 2020

@paulodamaso the pull request also available, we can define white list or blacklist with extensions....

@pnatashap
Copy link
Contributor

pnatashap commented Mar 29, 2024

@yegor256 @dgroup issue can be closed, rule should be applied to java files only

<module name="RegexpSingleline">
<property name="format" value="\s+$"/>
<property name="fileExtensions" value="java"/>
<property name="message" value="Line has trailing spaces."/>
</module>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants