Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1055: RegexpSinglelineCheck applies to *.png, *.js, *.css files #1056

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

dgroup
Copy link
Contributor

@dgroup dgroup commented Jun 23, 2019

@0crat
Copy link
Collaborator

0crat commented Jun 23, 2019

@krzyk/z please, pay attention to this pull request

@0crat
Copy link
Collaborator

0crat commented Jun 23, 2019

@dgroup/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @krzyk/z please review this and merge or reject

@krzyk
Copy link
Collaborator

krzyk commented Jun 23, 2019

@dgroup we want this to apply also to other file types, not only java, so I'm not sure how to do it, a black list or a white list of extensions. Or maybe some clever binary file recognition.

@dgroup
Copy link
Contributor Author

dgroup commented Jun 23, 2019

@krzyk , can you define the list of the supported files?
The fileExtensions supports multiple extensions thus we can list them.
This doesn't look complex.
For example, java, xml, txt, yml, yaml, json as aW/A for now.

A more complex solution like clever binary file recognition we can place to the backlog.

@dgroup
Copy link
Contributor Author

dgroup commented Jun 30, 2019

@krzyk , @yegor256 , @davvd ,
can you define the list of the supported files for this rule?
The fileExtensions supports multiple extensions thus we can list them.

@dgroup
Copy link
Contributor Author

dgroup commented Jul 10, 2019

@krzyk , up

@dgroup
Copy link
Contributor Author

dgroup commented Jul 16, 2019

@krzyk up

3 similar comments
@dgroup
Copy link
Contributor Author

dgroup commented Jul 20, 2019

@krzyk up

@dgroup
Copy link
Contributor Author

dgroup commented Aug 20, 2019

@krzyk up

@dgroup
Copy link
Contributor Author

dgroup commented Apr 18, 2020

@krzyk up

@dgroup
Copy link
Contributor Author

dgroup commented Jun 7, 2020

@krzyk @yegor256 , up.
Could you please have a look into this issue.
The PR is available.

@yegor256
Copy link
Owner

yegor256 commented Oct 1, 2021

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 1, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 97a35d2 into yegor256:master Oct 1, 2021
@rultor
Copy link
Collaborator

rultor commented Oct 1, 2021

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants