Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check for pmd analyse ".java" files only #1195

Closed
wants to merge 1 commit into from
Closed

Move check for pmd analyse ".java" files only #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions qulice-pmd/src/main/java/com/qulice/pmd/PmdListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,9 @@ public void ruleViolationAdded(final RuleViolation violation) {
/**
* Registers a new ProcessingError.
* @param error A processing error that needs to be reported.
* @todo #1129 If was added to avoid failing build, but there should be
* better place for this check.
*/
public void onProcessingError(final ProcessingError error) {
if (error.getFile().endsWith(".java")) {
this.errors.add(new PmdError.OfProcessingError(error));
}
this.errors.add(new PmdError.OfProcessingError(error));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion qulice-pmd/src/main/java/com/qulice/pmd/PmdValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public Collection<DataSource> getNonExcludedFiles(final Collection<File> files)
final String name = file.getPath().substring(
this.env.basedir().toString().length()
);
if (!this.env.exclude("pmd", name)) {
if (name.endsWith(".java") && !this.env.exclude("pmd", name)) {
sources.add(new FileDataSource(file));
}
}
Expand Down