-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visit package definitions in MultilineJavadocTagsCheck #1271
Conversation
@MikailBag it is good to have tests for the change to understand the reason for the change |
1355808
to
1f63462
Compare
1f63462
to
943e47d
Compare
@pnatashap I updated test so that it contains a PACKAGE_DEV token. Manual testing shows that it is emitted in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid formatting this comment also should be added to test to make sure that we do not raise error on it
Thank you for comment, I've added a doc-comment to Valid.java. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@yegor256 please take a look |
@rultor merge |
Should fix #1072