Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suppress warnings in Violation #1278

Merged
merged 1 commit into from
May 16, 2024

Conversation

MikailBag
Copy link
Contributor

Default threshold is 10 methods, and Violation interface has only 5, so there is no need to suppress anything

@MikailBag MikailBag marked this pull request as ready for review May 13, 2024 12:39
@pnatashap
Copy link
Contributor

@yegor256 please take a look

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 16, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 16, 2024

@rultor merge

@MikailBag @yegor256 Oops, I failed. You can see the full log here (spent 12min)

[INFO] Executing tasks
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/checkstyle-newlines/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/checkstyle-violations/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/dependency-not-matches-exclude/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/dependency-not-matches-exclude/src/main/java/com/qulice/entity/hibernate.cfg.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/dependency-violations-exclude/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/dependency-violations/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/duplicate-finder-ignore-deps/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/duplicate-finder-violations/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/hibernate-validator-check/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/log-check/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/multi-module/mod-alpha/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/multi-module/mod-tk/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/multi-module/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/pmd-violations/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/pom-xpath-validator-violations/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/relocation/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/settings.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/it/snapshots/pom.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/site/site.xml looks good
[INFO]      [exec] /home/r/repo/qulice-maven-plugin/src/test/resources/com/qulice/maven/PomXpathValidator/pom.xml looks good
[INFO] Executed tasks
[INFO] 
[INFO] --- install:3.1.1:install (default-install) @ qulice-maven-plugin ---
[INFO] Installing /home/r/repo/qulice-maven-plugin/pom.xml to /home/r/.m2/repository/com/qulice/qulice-maven-plugin/1.0-SNAPSHOT/qulice-maven-plugin-1.0-SNAPSHOT.pom
[INFO] Installing /home/r/repo/qulice-maven-plugin/target/qulice-maven-plugin-1.0-SNAPSHOT.jar to /home/r/.m2/repository/com/qulice/qulice-maven-plugin/1.0-SNAPSHOT/qulice-maven-plugin-1.0-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for qulice 1.0-SNAPSHOT:
[INFO] 
[INFO] qulice ............................................. SUCCESS [ 20.039 s]
[INFO] qulice-spi ......................................... SUCCESS [ 45.511 s]
[INFO] qulice-checkstyle .................................. SUCCESS [ 46.618 s]
[INFO] qulice-pmd ......................................... SUCCESS [ 42.379 s]
[INFO] qulice-maven-plugin ................................ SUCCESS [04:17 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  07:01 min
[INFO] Finished at: 2024-05-16T13:25:15Z
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "qulice-profile" could not be activated because it does not exist.
\u001b[0m\u001b[0m+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R ubuntu repo
+ cd repo
+ git push origin master
To github.com:yegor256/qulice.git
 ! [rejected]          master -> master (fetch first)
error: failed to push some refs to 'github.com:yegor256/qulice.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container f091c9ada257863021645161c0e5766366d50b4db7917e08e26c3cd077f97135 is dead
Thu May 16 13:25:24 UTC 2024

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 16, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e1a7255 into yegor256:master May 16, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented May 16, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants