Moved to vanilla JS #1359

Piterden · 2022-01-14T16:56:17Z

Code makes same things if we suppose there is only one <img> inside target <div>

Code makes same things if we suppose there is only one `<img>` inside target `<div>`

yegor256 · 2022-06-28T04:46:23Z

src/main/js/siblings.js

@@ -28,37 +28,54 @@
 * OF THE POSSIBILITY OF SUCH DAMAGE.
 */

-/*globals $:false, document:false, window:false */
+document.addEventListener('DOMContentReady', function () {


Codacy has a fix for the issue: Replace 'DOMContentReady' with "DOMContentReady"

Suggested change

document.addEventListener('DOMContentReady', function () {

document.addEventListener("DOMContentReady", function () {

yegor256 · 2022-06-28T04:46:24Z

src/main/js/home.js

@@ -28,20 +28,11 @@
 * OF THE POSSIBILITY OF SUCH DAMAGE.
 */

-/*globals $:false, document:false, window:false */
+document.addEventListener('DOMContentReady', function () {


Codacy has a fix for the issue: Replace 'DOMContentReady' with "DOMContentReady"

Suggested change

document.addEventListener('DOMContentReady', function () {

document.addEventListener("DOMContentReady", function () {

yegor256 · 2022-06-28T04:46:25Z

src/main/js/siblings.js

+      })
+        .then(function (res) { return res.text(); })
+        .catch(function (error) {
+          $tail.innerText = 'Oops, an error :( Please, try to reload the page';


Codacy has a fix for the issue: Replace 'Oops,·an·error·:(·Please,·try·to·reload·the·page' with "Oops,·an·error·:(·Please,·try·to·reload·the·page"

Suggested change

$tail.innerText = 'Oops, an error :( Please, try to reload the page';

$tail.innerText = "Oops, an error :( Please, try to reload the page";

yegor256 · 2022-06-28T04:46:27Z

src/main/js/siblings.js

-              }
-            }
-          );
+  function needMore () {


Codacy has a fix for the issue: Delete ·

Suggested change

function needMore () {

function needMore() {

yegor256 · 2022-06-28T04:46:28Z

src/main/js/siblings.js

-);
+
+  window.addEventListener('scroll', changeHandler);
+  window.addEventListener('resize', changeHandler);


Codacy has a fix for the issue: Replace 'resize' with "resize"

Suggested change

window.addEventListener('resize', changeHandler);

window.addEventListener("resize", changeHandler);

yegor256 · 2022-06-28T04:46:29Z

src/main/js/siblings.js

+          'Content-Type': 'text/xml',
+        },
+      })
+        .then(function (res) { return res.text(); })


Codacy has a fix for the issue: Replace ·return·res.text(); with ⏎··········return·res.text();⏎·······

Suggested change

.then(function (res) { return res.text(); })

.then(function (res) {

yegor256 · 2022-06-28T04:46:30Z

src/main/js/home.js

@@ -28,20 +28,11 @@
 * OF THE POSSIBILITY OF SUCH DAMAGE.
 */

-/*globals $:false, document:false, window:false */
+document.addEventListener('DOMContentReady', function () {
+  var $div = document.getElementById('pulse');


Codacy has a fix for the issue: Replace 'pulse' with "pulse"

Suggested change

var $div = document.getElementById('pulse');

var $div = document.getElementById("pulse");

yegor256 · 2022-06-28T04:46:31Z

src/main/js/siblings.js

+      if (data) {
+        var parser = new DOMParser();
+        var $fragment = parser.parseFromString(data, 'text/xml');
+        var $newBox = fragment.getElementById('talks');


Codacy has a fix for the issue: Replace 'talks' with "talks"

Suggested change

var $newBox = fragment.getElementById('talks');

var $newBox = fragment.getElementById("talks");

yegor256 · 2022-06-28T04:46:32Z

src/main/js/siblings.js

  }
-);
+
+  window.addEventListener('scroll', changeHandler);


Codacy has a fix for the issue: Replace 'scroll' with "scroll"

Suggested change

window.addEventListener('scroll', changeHandler);

window.addEventListener("scroll", changeHandler);

yegor256 · 2022-06-28T04:46:33Z

src/main/js/siblings.js

        }
+        $box.dataset.more = $newBox.dataset.more;
+        $tail.style.display = 'none';


Codacy has a fix for the issue: Replace 'none' with "none"

Suggested change

$tail.style.display = 'none';

$tail.style.display = "none";

yegor256 · 2022-06-28T04:46:34Z

src/main/js/siblings.js

+
+      if (data) {
+        var parser = new DOMParser();
+        var $fragment = parser.parseFromString(data, 'text/xml');


Codacy has a fix for the issue: Replace 'text/xml' with "text/xml"

Suggested change

var $fragment = parser.parseFromString(data, 'text/xml');

var $fragment = parser.parseFromString(data, "text/xml");

Moved to vanilla JS

0f53ffa

Code makes same things if we suppose there is only one `<img>` inside target `<div>`

0crat added the 0crat/new label Jan 14, 2022

Piterden added 7 commits January 15, 2022 04:48

Siblings to vanilla JS. JQ removed from layout

4b422b3

Fix es5 only

e619374

Added ES6

03fd6ac

Fixed argument

7567f05

Removed es6 features

f74fb6a

Removed const/let

bf0d6ae

Update minify plugin

c60ed5b

Piterden marked this pull request as ready for review January 15, 2022 06:41

yegor256 reviewed Jun 28, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moved to vanilla JS #1359

Moved to vanilla JS #1359

Piterden commented Jan 14, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

yegor256 Jun 28, 2022

	document.addEventListener('DOMContentReady', function () {
	document.addEventListener("DOMContentReady", function () {

	$tail.innerText = 'Oops, an error :( Please, try to reload the page';
	$tail.innerText = "Oops, an error :( Please, try to reload the page";

	window.addEventListener('resize', changeHandler);
	window.addEventListener("resize", changeHandler);

	.then(function (res) { return res.text(); })
	.then(function (res) {

	var $div = document.getElementById('pulse');
	var $div = document.getElementById("pulse");

	var $newBox = fragment.getElementById('talks');
	var $newBox = fragment.getElementById("talks");

	window.addEventListener('scroll', changeHandler);
	window.addEventListener("scroll", changeHandler);

	var $fragment = parser.parseFromString(data, 'text/xml');
	var $fragment = parser.parseFromString(data, "text/xml");

Moved to vanilla JS #1359

Are you sure you want to change the base?

Moved to vanilla JS #1359

Conversation

Piterden commented Jan 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment