Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
rultor committed Dec 6, 2018
2 parents 95cd94f + 9ef766a commit 1a11256
Show file tree
Hide file tree
Showing 2 changed files with 78 additions and 2 deletions.
3 changes: 1 addition & 2 deletions src/main/java/org/takes/rs/RsPrint.java
Expand Up @@ -167,10 +167,9 @@ public void printHead(final Writer writer) throws IOException {
* @throws IOException If fails
*/
public void printBody(final OutputStream output) throws IOException {
final InputStream body = this.body();
//@checkstyle MagicNumberCheck (1 line)
final byte[] buf = new byte[4096];
try {
try (final InputStream body = this.body()) {
while (true) {
final int bytes = body.read(buf);
if (bytes < 0) {
Expand Down
77 changes: 77 additions & 0 deletions src/test/java/org/takes/rs/RsPrintTest.java
Expand Up @@ -24,17 +24,22 @@
package org.takes.rs;

import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.Writer;
import java.nio.charset.StandardCharsets;
import org.cactoos.io.InputStreamOf;
import org.hamcrest.MatcherAssert;
import org.hamcrest.Matchers;
import org.hamcrest.core.IsEqual;
import org.junit.Test;

/**
* Test case for {@link RsPrint}.
* @since 0.8
* @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
*/
@SuppressWarnings("PMD.TooManyMethods")
public final class RsPrintTest {

/**
Expand Down Expand Up @@ -68,6 +73,30 @@ public void flushBodyEvenWhenExceptionHappens() throws IOException {
);
}

/**
* RsPrint can close body contents even when exception happens.
* @throws IOException If some problem inside
*/
@Test
public void closeBodyEvenWhenExceptionHappens() throws IOException {
final IOException exception = new IOException("Smth went wrong");
final FailOutputStream output = new FailOutputStream(exception);
final FakeInput input = new FakeInput(new InputStreamOf("abc"));
try {
new RsPrint(new RsText(input))
.printBody(output);
} catch (final IOException ex) {
if (!ex.equals(exception)) {
throw ex;
}
}
MatcherAssert.assertThat(
"Input body was not closed",
input.isClosed(),
new IsEqual<>(true)
);
}

/**
* RsPrint can flush head contents even when exception happens.
* @throws IOException If some problem inside
Expand Down Expand Up @@ -184,4 +213,52 @@ public boolean haveFlushed() {
return this.flushed;
}
}

/**
* Fake wrapper for InputStream to make sure body is closed.
*
* @author Alena Gerasimova (olena.gerasimova@gmail.com)
* @version $Id$
* @since 2.0
*/
private static final class FakeInput extends InputStream {

/**
* Have input been closed?
*/
private boolean closed;

/**
* Origin.
*/
private final InputStream origin;

/**
* Ctor.
* @param origin Origin input
*/
FakeInput(final InputStream origin) {
super();
this.origin = origin;
}

@Override
public int read() throws IOException {
return this.origin.read();
}

@Override
public void close() throws IOException {
this.origin.close();
this.closed = true;
}

/**
* Have input been closed?
* @return True, if input wes closed, false - otherwise
*/
public boolean isClosed() {
return this.closed;
}
}
}

0 comments on commit 1a11256

Please sign in to comment.