Skip to content

Commit

Permalink
Continue to remove nulls as requested in PR #802
Browse files Browse the repository at this point in the history
  • Loading branch information
marceloamadeu committed Jan 4, 2019
1 parent 6e4df63 commit b9f248e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/main/java/org/takes/facets/fork/FkHitRefresh.java
Expand Up @@ -234,9 +234,10 @@ private boolean expired() throws IOException {
/**
* Directory contents updated?
* @return TRUE if contents were updated
* @todo #744:30min `null` constant usage in the function
* `directoryUpdated` is violating the key principles, defined
* in README.md file and must be eliminated.
* @todo #802:30min Continue removing nulls from the codebase,
* which still exist in the code. The way it is violates
* the key principles, defined in the README.md file and should be
* deleted.
*/
private boolean directoryUpdated() {
final long recent;
Expand All @@ -248,7 +249,7 @@ private boolean directoryUpdated() {
}
final File[] files = this.dir.listFiles();
boolean expired = false;
if (files != null) {
if (new Opt.Single<>(files).has()) {
for (final File file : files) {
if (file.lastModified() > recent) {
expired = true;
Expand Down

2 comments on commit b9f248e

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on b9f248e Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 744-7f6a14c2 disappeared from src/main/java/org/takes/facets/fork/FkHitRefresh.java, that's why I closed #802. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on b9f248e Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 802-a1804963 discovered in src/main/java/org/takes/facets/fork/FkHitRefresh.java and submitted as #935. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.