Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HmRsBody matcher for checking response body #485

Closed
carlosmiranda opened this issue Dec 26, 2015 · 38 comments
Closed

HmRsBody matcher for checking response body #485

carlosmiranda opened this issue Dec 26, 2015 · 38 comments

Comments

@carlosmiranda
Copy link

At the moment we have HmRsHeader and HmRsStatus which allows us to use Hamcrest to match against Response headers or status codes, respectively.

It would be good if we have a class HmRsBody that will allow us to match the Response body as well. Let's create one, with public constructors that can accept Matcher<String> and Matcher<byte[]>, to support both text and binary responses.

@exper0
Copy link
Contributor

exper0 commented Dec 27, 2015

@carlosmiranda @davvd ready to take this

@carlosmiranda
Copy link
Author

@yegor256 what do you think?

@davvd
Copy link

davvd commented Dec 31, 2015

@yegor256 dispatch this issue please, see par.21

@carlosmiranda
Copy link
Author

@yegor256 ping

@yegor256 yegor256 added the bug label Jan 4, 2016
@davvd
Copy link

davvd commented Jan 4, 2016

@carlosmiranda attached this issue to milestone "1.0" (let me know if this is wrong)

@davvd davvd added this to the 1.0 milestone Jan 4, 2016
@davvd
Copy link

davvd commented Jan 4, 2016

@carlosmiranda thanks for the report, I topped your acc for 15 mins, payment ID 73824706

@davvd
Copy link

davvd commented Jan 7, 2016

@rfqu this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions; 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

@davvd davvd added the @rfqu label Jan 7, 2016
@akaigoro
Copy link

I am almost done, but one of new tests fails because of the issue #524.

@yegor256
Copy link
Owner

@rfqu keep in mind that you should address your messages to someone, by starting them with the name of the person you're talking to. otherwise, it's just noise, nobody will pay attention to what you're saying. check this out: http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#4.-avoid-noise-—-address-your-comments

@davvd
Copy link

davvd commented Jan 23, 2016

@rfqu the ticket is with you for 15 days already. If it is not finished in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle, this article should help if you're stuck. added -30 to your rating, now it is equal to -30

@akaigoro
Copy link

@davvd @yegor256 @carlosmiranda fixed - see pull request #545

@carlosmiranda
Copy link
Author

@rfqu let's wait for merge.

@davvd
Copy link

davvd commented Jan 25, 2016

@davvd @yegor256 @carlosmiranda fixed - see pull request #545

@rfqu thanks, I'll take a look

@akaigoro
Copy link

@yegor256 I see you "improved" code validator so that it blocks writing any complex programs - see issue #550

@davvd
Copy link

davvd commented Jan 28, 2016

@rfqu you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle... added -60 to your rating, now it is equal to -75

@akaigoro
Copy link

@davvd @yegor256 actually I finished this task. But your code validator rejects the solution for an idiotic reason.
I propose to accept issue #559, drop ConfusingTernary check, and pay for my solution.

@davvd davvd removed the @rfqu label Jan 28, 2016
@davvd
Copy link

davvd commented Jan 28, 2016

@danff please proceed, it's yours

@davvd davvd added the @danff label Jan 28, 2016
@ghost
Copy link

ghost commented Feb 12, 2016

@davvd need more time

@davvd
Copy link

davvd commented Feb 12, 2016

@davvd need more time

@danff OK, take your time

@yegor256
Copy link
Owner

@0crat in

@0crat
Copy link
Collaborator

0crat commented Aug 14, 2017

@0crat in (here)

@yegor256 Job gh:yegor256/takes#485 is in scope.

@0crat
Copy link
Collaborator

0crat commented Aug 14, 2017

Job gh:yegor256/takes#485 assigned to @caarlos0, please go ahead (policy).

@0crat
Copy link
Collaborator

0crat commented Nov 16, 2017

@caarlos0 this job was assigned to you 8 days ago.
It will be taken away from you after 10 days from start (this is our policy).

@0crat
Copy link
Collaborator

0crat commented Nov 16, 2017

Oops! Job gh:yegor256/takes#485 is not assigned to anyone.

2 similar comments
@0crat
Copy link
Collaborator

0crat commented Nov 16, 2017

Oops! Job gh:yegor256/takes#485 is not assigned to anyone.

@0crat
Copy link
Collaborator

0crat commented Nov 16, 2017

Oops! Job gh:yegor256/takes#485 is not assigned to anyone.

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

The job #485 assigned to @t-izbassar/z. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@t-izbassar
Copy link
Contributor

t-izbassar commented Jan 30, 2018

@0crat waiting for #785

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2018

@0crat waiting for #778 (here)

@t-izbassar The impediment for #485 was registered successfully by @t-izbassar/z

t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Jan 31, 2018
t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Feb 6, 2018
t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Feb 6, 2018
@t-izbassar
Copy link
Contributor

@carlosmiranda can you close this one? #785 was merged and puzzles created.

@carlosmiranda
Copy link
Author

@t-izbassar thanks!

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

Order was successfully finished: +30 points just awarded to @t-izbassar/z, total is +225

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

The job #485 is now out of scope

@0pdd
Copy link
Collaborator

0pdd commented Mar 17, 2018

@carlosmiranda 3 puzzles #819, #820, #832 are still not solved; solved: #794, #795.

@0pdd
Copy link
Collaborator

0pdd commented Oct 11, 2018

@carlosmiranda 3 puzzles #819, #832, #859 are still not solved; solved: #794, #795, #820.

@0pdd
Copy link
Collaborator

0pdd commented Oct 11, 2018

@carlosmiranda 2 puzzles #819, #832 are still not solved; solved: #794, #795, #820, #859.

@0pdd
Copy link
Collaborator

0pdd commented Oct 14, 2018

@carlosmiranda the puzzle #819 is still not solved; solved: #794, #795, #820, #832, #859.

@0pdd
Copy link
Collaborator

0pdd commented Nov 29, 2018

@carlosmiranda all 6 puzzles are solved here: #794, #795, #819, #820, #832, #859.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants