Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractHmBody.java:43-58: Right now we can only check... #794

Closed
0pdd opened this issue Feb 9, 2018 · 16 comments
Closed

AbstractHmBody.java:43-58: Right now we can only check... #794

0pdd opened this issue Feb 9, 2018 · 16 comments
Labels
bug pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Feb 9, 2018

The puzzle 485-ca1df145 from #485 has to be resolved:

takes/src/main/java/org/takes/facets/hamcrest/AbstractHmBody.java

Lines 43 to 58 in a98eb96

* @todo #485:30min Right now we can only check that InputStream
* have the same content as other InputStream. This is very
* limited usage. Task is to introduce `HmTextBody` that will
* make available to us to use useful string matchers from
* hamcrest. The usage will be like that:
* ```
* MatcherAssert.assertThat(
* response,
* new HmRsTextBody<>(Matchers.startsWith("<html>"))
* );
* ```
* The default constructor should use `Matcher.containsString`
* as default matcher, which is used for matching string to body.
* Current implementation of `AbstractHmBody` should be converted
* to `HmBytesBody` that will check equality of bytes. We can think
* of improving that class lately.

The puzzle was created by rultor on 09-Feb-18.

Estimate: 30 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Feb 9, 2018
@rultor
Merge branch '__rultor'
a98eb96
@0crat
Copy link
Collaborator

0crat commented Feb 9, 2018

@yegor256/z please, pay attention to this issue

@0crat 0crat added the scope label Feb 9, 2018
@0crat
Copy link
Collaborator

0crat commented Feb 9, 2018

Job #794 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Feb 28, 2018

The job #794 assigned to @t-izbassar/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Feb 28, 2018
yegor256#794 Introduce HmTextBody matchers
76917b2
@t-izbassar t-izbassar mentioned this issue Feb 28, 2018
Merged
@t-izbassar
Copy link
Contributor

@0pdd partially done in #813. Left puzzle to address what was left.

t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Mar 3, 2018
yegor256#794 Replace containsString with equalTo
a39db8b
t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Mar 3, 2018
yegor256#794 Modify puzzle to update the describeTo as well
f6c48c0
@t-izbassar
Copy link
Contributor

@0crat waiting for #813 to be merged

@0crat
Copy link
Collaborator

0crat commented Mar 4, 2018

@0crat waiting for #813 to be merged (here)

@t-izbassar The impediment for #794 was registered successfully by @t-izbassar/z

@0pdd 0pdd closed this as completed Mar 5, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 5, 2018

The puzzle 485-ca1df145 has disappeared from the source code, that's why I closed this issue.

0pdd referenced this issue Mar 5, 2018
@rultor
Merge branch '__rultor'
7fb5241
This was referenced Mar 5, 2018
Closed
Closed
@0crat
Copy link
Collaborator

0crat commented Mar 5, 2018

@elenavolokhova/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@elenavolokhova
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Mar 6, 2018

@0crat quality good (here)

@elenavolokhova You can't do that, unless you have one of these roles: ARC, PO. Your current roles are: QA.

@0crat
Copy link
Collaborator

0crat commented Mar 6, 2018

QA review completed: +8 points just awarded to @elenavolokhova/z

@0crat 0crat removed the scope label Mar 6, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 6, 2018

Order was finished, quality was "good": +35 points just awarded to @t-izbassar/z

@0crat
Copy link
Collaborator

0crat commented Mar 6, 2018

@0crat quality good (here)

@elenavolokhova The job #794 is now out of scope

@0pdd 0pdd mentioned this issue Mar 17, 2018
Closed
@0pdd 0pdd mentioned this issue Oct 11, 2018
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Oct 11, 2018

@0pdd 2 puzzles #819, #859 are still not solved; solved: #820.

@0pdd
Copy link
Collaborator Author

0pdd commented Oct 11, 2018

@0pdd the puzzle #819 is still not solved; solved: #820, #859.

@0pdd
Copy link
Collaborator Author

0pdd commented Nov 29, 2018

@0pdd all 3 puzzles are solved here: #819, #820, #859.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pdd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elenavolokhova @t-izbassar @0crat @0pdd