Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nulls #863

Closed
paulodamaso opened this issue Oct 23, 2018 · 19 comments
Closed

Remove nulls #863

paulodamaso opened this issue Oct 23, 2018 · 19 comments

Comments

@paulodamaso
Copy link
Contributor

paulodamaso commented Oct 23, 2018

There are a lot of null usages in the project violating the key principles defined README.md file. These null constant references must be eliminated.

@paulodamaso
Copy link
Contributor Author

@0crat in

@0crat 0crat added the scope label Oct 23, 2018
@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

@0crat in (here)

@paulodamaso Job #863 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Bug was reported, see §29: +15 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Dec 6, 2018

The job #863 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@krzyk
Copy link
Contributor

krzyk commented Dec 6, 2018

@paulodamaso What to do in case of receiving null from external libraries, or a call to external library requires null in params to enable some option?
In case of return params we could hide null inside Optional or Opt

I think the last time nulls were being removed (#555) here we stopped at those boundaries.

@paulodamaso
Copy link
Contributor Author

@krzyk I think that we have to evaluate each case of null when communicating with other libraries, so let's not assume any default behavior for now.

Takes code deteriorated from last null removal to now; we have a lot of "new nulls" lurking in our own code right now. Let's take care of these ones first.

@krzyk
Copy link
Contributor

krzyk commented Dec 15, 2018

@0crat wait I'm busy with other tasks

@0crat
Copy link
Collaborator

0crat commented Dec 15, 2018

@0crat wait I'm busy with other tasks (here)

@krzyk The impediment for #863 was registered successfully by @krzyk/z

@0pdd
Copy link
Collaborator

0pdd commented Dec 26, 2018

@paulodamaso the puzzle #917 is still not solved.

@krzyk
Copy link
Contributor

krzyk commented Dec 26, 2018

@paulodamaso please close this issue, it has been merged to master in #907

@paulodamaso
Copy link
Contributor Author

@krzyk Great, thanks!

@0crat
Copy link
Collaborator

0crat commented Dec 26, 2018

@ypshenychka/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Dec 26, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 26, 2018

The job #863 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2022

@paulodamaso the puzzle #unknown is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants