#863 removed some nulls #907
Conversation
|
Job #907 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
============================================
+ Coverage 74.1% 74.19% +0.08%
+ Complexity 959 953 -6
============================================
Files 220 220
Lines 4731 4723 -8
Branches 372 364 -8
============================================
- Hits 3506 3504 -2
Misses 1071 1071
+ Partials 154 148 -6
Continue to review full report at Codecov.
|
|
@paulodamaso ping |
| @@ -48,8 +48,7 @@ public void accept(final Socket socket) { | |||
| try { | |||
| back.accept(socket); | |||
| // @checkstyle IllegalCatchCheck (1 line) | |||
| } catch (final Throwable ex) { | |||
| assert ex != null; | |||
| } catch (final Throwable ignored) { | |||
There was a problem hiding this comment.
@krzyk Why just ignore this exception?
There was a problem hiding this comment.
@paulodamaso because it was ignored already, I just removed null, I didn't want to change the functionality.
| @@ -112,8 +112,7 @@ public void start(final Exit exit) throws IOException { | |||
| private void loop(final ServerSocket server) throws IOException { | |||
| try { | |||
| this.back.accept(server.accept()); | |||
| } catch (final SocketTimeoutException ex) { | |||
| assert ex != null; | |||
| } catch (final SocketTimeoutException ignored) { | |||
There was a problem hiding this comment.
@krzyk Why just ignore this exception?
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 18min) |
|
Job |
|
The job #907 is now out of scope |
#863
nullinstances