#866 ResponseOf unit tests

[fabriciofx]

As per #866.

Unit tests for ResponseOf class and a HttpServletResponseFake to support.

[codecov-io]

Codecov Report

Merging #930 into master will increase coverage by 0.04%.
The diff coverage is 43.66%.

@@             Coverage Diff              @@
##             master     #930      +/-   ##
============================================
+ Coverage     74.09%   74.14%   +0.04%     
- Complexity      954      971      +17     
============================================
  Files           220      222       +2     
  Lines          4714     4785      +71     
  Branches        360      361       +1     
============================================
+ Hits           3493     3548      +55     
- Misses         1074     1086      +12     
- Partials        147      151       +4

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/takes/servlet/RqFrom.java	0% <ø> (ø)	0 <0> (ø)	⬇️
src/main/java/org/takes/servlet/ResponseOf.java	82.75% <ø> (+82.75%)	7 <0> (+7)	⬆️
...ava/org/takes/servlet/HttpServletResponseFake.java	43.33% <43.33%> (ø)	8 <8> (?)
.../java/org/takes/servlet/ServletOutputStreamTo.java	45.45% <45.45%> (ø)	2 <2> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4df63...ab2d8d6. Read the comment docs.

[0crat]

Job #930 is now in scope, role is REV

[0crat]

This pull request #930 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[marceloamadeu]

@rultor merge please

[rultor]

@rultor merge please

@marceloamadeu Thanks for your request. @paulodamaso Please confirm this.

[paulodamaso]

@rultor merge

[rultor]

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 20min)

[0crat]

@ypshenychka/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

Code review was too long (8 days), architects (@paulodamaso) were penalized, see §55

[0crat]

The job #930 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

[ypshenychka]

@marceloamadeu According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

No issues were found during code review.
Please confirm that you'll try to find at least three major problems while future reviews.

[marceloamadeu]

@ypshenychka Okay ... I'm going to look for the 3 biggest problems.

[ypshenychka]

@marceloamadeu thanks

[ypshenychka]

@0crat quality bad

[0crat]

Quality is low, no payment, see §31

[0crat]

@0crat quality bad (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

[fabriciofx]

@ypshenychka Just for curiosity, why the quality was bad? I didn't get any review from REV. Besides, the ARC merged this PR.

[ypshenychka]

@fabriciofx Quality is bad since reviewer didn't find any issues and thus he can't be paid here.