Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#968 I kept removing guava's #973

Closed
wants to merge 4 commits into from

Conversation

lucasmessias9898
Copy link

For #968:
I kept removing guava's

@0crat 0crat added the scope label Mar 27, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 27, 2019

Job #973 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Mar 27, 2019

This pull request #973 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@marceloamadeu
Copy link
Contributor

@lucasmessias9898 Please correct the conflicts.

@marceloamadeu
Copy link
Contributor

@lucasmessias9898 ping

@marceloamadeu
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

@0crat refuse (here)

@marceloamadeu The user @marceloamadeu/z resigned from #973, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @marceloamadeu/z

@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

This pull request #973 is assigned to @Serranya/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Copy link
Contributor

@Serranya Serranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso looking good

@Serranya
Copy link
Contributor

@lucasmessias9898 There are CI failures. Please fix the tests and update this PR

@Serranya
Copy link
Contributor

Serranya commented May 2, 2019

@lucasmessias9898 ping

@Serranya
Copy link
Contributor

Serranya commented May 14, 2019

@lucasmessias9898 ping

cc @paulodamaso

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2020

@sereshqua/z please review this job completed by @Serranya/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2020

Code review was too long (277 days), architects (@paulodamaso) were penalized, see §55

@0crat 0crat removed the scope label Jan 28, 2020
@0crat
Copy link
Collaborator

0crat commented Jan 28, 2020

Pull request #973 was not merged, no payment for ARC, see §28

@sereshqua
Copy link

@Serranya please make sure you will try to find at least 3 issues during next CR

@sereshqua
Copy link

@Serranya ping

@sereshqua
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Feb 1, 2020

Order was finished, quality is "acceptable": +15 point(s) just awarded to @Serranya/z

@0crat
Copy link
Collaborator

0crat commented Feb 1, 2020

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants