For #968. Removing Guava's code. #979
Conversation
|
Job #979 is now in scope, role is |
|
This pull request #979 is assigned to @Serranya/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
|
Job was finished in 10 hours, bonus for fast delivery is possible (see §36) |
|
@sereshqua/z please review this job completed by @Serranya/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #979 is now out of scope |
|
@Serranya did you make code review at all? I don't see your comments and also i don't see these problems fixed; @zCRUSADERz am I missing smth? |
|
@sereshqua I have not fully studied the problem, so I closed the PR until I correct the shortcomings |
|
@zCRUSADERz The job is closed only when the reported problem is solved |
|
@0crat quality good bad |
|
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
|
@sereshqua I thought to reopen PR when I correct the shortcomings. Now I need to open a new PR? |
|
@zCRUSADERz oops, i just noticed TYPO in quality result, it should have been bad; I believe new issue needs to be opened if this is not solved |
|
@sereshqua I did not do a quality review. The PR was retracted before that. |
|
@Serranya well, then it is a zerocrat bug... it was assigned to me to check your work |
For #968