#98 aibolit.P13 fixed in RemoveDirective

yegor256 · Jul 13, 2020 · 722f424 · 722f424
1 parent 342577a
commit 722f424
Showing 1 changed file with 25 additions and 15 deletions.
diff --git a/src/main/java/org/xembly/RemoveDirective.java b/src/main/java/org/xembly/RemoveDirective.java
@@ -56,23 +56,33 @@ public Directive.Cursor exec(final Node dom,
         final Directive.Cursor cursor, final Directive.Stack stack) {
         final Collection<Node> parents = new HashSet<>(cursor.size());
         for (final Node node : cursor) {
-            final Node parent;
-            if (node.getNodeType() == Node.ATTRIBUTE_NODE) {
-                final Attr attr = Attr.class.cast(node);
-                parent = attr.getOwnerElement();
-                Element.class.cast(parent).removeAttributeNode(attr);
-            } else {
-                parent = node.getParentNode();
-                if (parent == null) {
-                    throw new IllegalArgumentException(
-                        "you can't delete root document element form XML"
-                    );
-                }
-                parent.removeChild(node);
-            }
-            parents.add(parent);
+            parents.add(RemoveDirective.parent(node));
         }
         return new DomCursor(parents);
     }
 
+    /**
+     * Convert it to the parent.
+     * @param node The node
+     * @return Its parent
+     */
+    @SuppressWarnings("aibolit.P13")
+    private static Node parent(final Node node) {
+        final Node parent;
+        if (node.getNodeType() == Node.ATTRIBUTE_NODE) {
+            final Attr attr = Attr.class.cast(node);
+            parent = attr.getOwnerElement();
+            Element.class.cast(parent).removeAttributeNode(attr);
+        } else {
+            parent = node.getParentNode();
+            if (parent == null) {
+                throw new IllegalArgumentException(
+                    "You can't delete root element from the XML"
+                );
+            }
+            parent.removeChild(node);
+        }
+        return parent;
+    }
+
 }