Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrading husky 2.6.0 and add eslintrc.js #288

Closed
wants to merge 1 commit into from
Closed

downgrading husky 2.6.0 and add eslintrc.js #288

wants to merge 1 commit into from

Conversation

bung87
Copy link

@bung87 bung87 commented Feb 15, 2020

https://github.com/typicode/husky/blob/master/src/installer/gitRevParse.ts#L9
typicode/husky#580

add eslintrc.js so the brand new package can pass npm run test

@SBoudrias
Copy link
Member

Can you explain what Husky 3.x is breaking on your side? It's unclear to me what's the issue from the issue you linked. Husky 3 has been working fine where I've used it.

@bung87
Copy link
Author

bung87 commented Feb 16, 2020

when generating new project , during post install husky ,when Setting up git hooks it will throw error , I'v tried multiple times.

Base automatically changed from master to main January 24, 2021 06:35
@glensc
Copy link

glensc commented Mar 22, 2022

you should create pull request per each feature.

  • husky change: questionable
  • eslint: probably would had been already merged if it wasn't combined with husky

@glensc
Copy link

glensc commented Mar 22, 2022

also, typicode/husky#580 is closed by now

@bung87 bung87 closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants