Skip to content

Commit

Permalink
fix a blunder where I swapped operands
Browse files Browse the repository at this point in the history
  • Loading branch information
WorldSEnder committed Jan 29, 2022
1 parent 06e736b commit c713027
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/yew/src/dom_bundle/blist.rs
Expand Up @@ -422,7 +422,7 @@ impl Reconcilable for VList {
test_log!("lefts: {:?}", lefts);
test_log!("rights: {:?}", rights);

if let Some(additional) = rights.len().checked_sub(lefts.len()) {
if let Some(additional) = lefts.len().checked_sub(rights.len()) {
rights.reserve_exact(additional);
}
let first = if self.fully_keyed && blist.fully_keyed {
Expand Down

1 comment on commit c713027

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yew master branch benchmarks (Lower is better)

Benchmark suite Current: c713027 Previous: 485a1b8 Ratio
yew-struct-keyed 01_run1k 160.127 276.214 0.58
yew-struct-keyed 02_replace1k 186.9495 253.064 0.74
yew-struct-keyed 03_update10th1k_x16 399.7845 446.37 0.90
yew-struct-keyed 04_select1k 85.53 79.6895 1.07
yew-struct-keyed 05_swap1k 91.4105 95.8995 0.95
yew-struct-keyed 06_remove-one-1k 29.038 32.419 0.90
yew-struct-keyed 07_create10k 2034.5225 2735.821 0.74
yew-struct-keyed 08_create1k-after1k_x2 388.862 560.5615 0.69
yew-struct-keyed 09_clear1k_x8 199.506 250.0145 0.80
yew-struct-keyed 21_ready-memory 0.9634513854980468 0.9634513854980468 1
yew-struct-keyed 22_run-memory 1.4538459777832031 1.4578094482421875 1.00
yew-struct-keyed 23_update5-memory 1.4615478515625 1.5065078735351562 0.97
yew-struct-keyed 24_run5-memory 1.510845184326172 1.5065422058105469 1.00
yew-struct-keyed 25_run-clear-memory 1.1287879943847656 1.1290855407714844 1.00
yew-struct-keyed 31_startup-ci 1732.818 1743.1039999999998 0.99
yew-struct-keyed 32_startup-bt 28.417999999999992 35.06999999999999 0.81
yew-struct-keyed 34_startup-totalbytes 367.962890625 364.2373046875 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.