New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow function_component
creation based on function name
#2292
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 8 additions & 6 deletions
14
packages/yew-macro/tests/function_component_attr/bad-name-fail.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,25 @@ | ||
error: expected identifier | ||
--> $DIR/bad-name-fail.rs:8:22 | ||
--> tests/function_component_attr/bad-name-fail.rs:8:22 | ||
| | ||
8 | #[function_component(let)] | ||
| ^^^ | ||
|
||
error: unexpected token | ||
--> $DIR/bad-name-fail.rs:17:23 | ||
--> tests/function_component_attr/bad-name-fail.rs:17:23 | ||
| | ||
17 | #[function_component(x, y, z)] | ||
| ^ | ||
|
||
error: expected identifier | ||
--> $DIR/bad-name-fail.rs:26:22 | ||
--> tests/function_component_attr/bad-name-fail.rs:26:22 | ||
| | ||
26 | #[function_component(124)] | ||
| ^^^ | ||
|
||
error: the component must not have the same name as the function | ||
--> $DIR/bad-name-fail.rs:35:22 | ||
warning: type `component` should have an upper camel case name | ||
--> tests/function_component_attr/bad-name-fail.rs:35:22 | ||
| | ||
35 | #[function_component(component)] | ||
| ^^^^^^^^^ | ||
| ^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Component` | ||
| | ||
= note: `#[warn(non_camel_case_types)]` on by default |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
packages/yew-macro/tests/function_component_attr/no-name-fail.stderr
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to convert the function name to PascalCase with convert_case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter since it's not in the public API. Besides, generally this name would be PascalCase anyway because that's the convention for component names.