Make layout testing code pub
#2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hamza1311
changed the title
pub
voidpumpkin
reviewed
Dec 28, 2021
| pub expected: &'a str, | ||
| } | ||
|
|
||
| pub fn diff_layouts(layouts: Vec<TestLayout<'_>>) { |
There was a problem hiding this comment.
What does layout mean in this context?
From the code it does not seem like it renders anything 🤔
There was a problem hiding this comment.
nvm i looked at the tests bellow, this does seem to be comparing html
voidpumpkin
approved these changes
Dec 28, 2021
|
I think i will open a separate PR to add docs and rename these tests to snapshot tests, so for now I'm merging this in |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the previously private
layout_testsmodule underyew::tests::layout_tests.Fixes #1413
TODO
It would be great if someone can describe the
diff_layoutsfunction. I'm can't come up with a way to describe that in docs.Checklist
cargo make pr-flow