Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.56 #2334

Merged
merged 5 commits into from Jan 6, 2022
Merged

Bump MSRV to 1.56 #2334

merged 5 commits into from Jan 6, 2022

Conversation

hamza1311
Copy link
Member

@hamza1311 hamza1311 commented Jan 6, 2022

Description

Bump MSRV to 1.56. A dependency of wasm-bindgen bumped it's MSRV so we need to as well.
Also see #2330 (comment)

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added this to the v0.20 milestone Jan 6, 2022
github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Visit the preview URL for this PR (updated for commit 7ceddb3):

https://yew-rs--pr2334-bump-msrv-6xvtgctb.web.app

(expires Thu, 13 Jan 2022 17:13:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@siku2
Copy link
Member

siku2 commented Jan 6, 2022

Just gotta fix the macro tests and we're good to go

github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2022
github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2022
@hamza1311 hamza1311 changed the title Bump MSRV to 1.54 Bump MSRV to 1.56 Jan 6, 2022
@voidpumpkin voidpumpkin added A-yew Area: The main yew crate A-yew-router Area: The yew-router crate labels Jan 6, 2022
@voidpumpkin voidpumpkin added the A-yew-agent Area: The yew-agent crate label Jan 6, 2022
@voidpumpkin voidpumpkin merged commit b456636 into yewstack:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-router Area: The yew-router crate breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants