Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to edition 2021 #2354

Merged
merged 2 commits into from Jan 12, 2022
Merged

Update to edition 2021 #2354

merged 2 commits into from Jan 12, 2022

Conversation

hamza1311
Copy link
Member

Description

Run cargo fix --edition

Fixes #2338

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Jan 10, 2022
View reviewed changes
@voidpumpkin voidpumpkin added the A-yew-macro Area: The yew-macro crate label Jan 11, 2022
@voidpumpkin voidpumpkin self-requested a review January 11, 2022 20:08
voidpumpkin
voidpumpkin requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think benchmarks are failing because you need to rebase

Madoshakalaka
Madoshakalaka suggested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@Madoshakalaka Madoshakalaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forget to do the most important thing,
change edition="2018" to edition="2021" in the Cargo.toml files

@hamza1311
Copy link
Member Author

You forget to do the most important thing, change edition="2018" to edition="2021" in the Cargo.toml files

Why doesn't cargo fix do this?!?

github-actions[bot]
github-actions bot previously approved these changes Jan 12, 2022
View reviewed changes
@hamza1311 hamza1311 added A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-router Area: The yew-router crate A-yew-router-macro Area: The yew-router-macro crate breaking change labels Jan 12, 2022
voidpumpkin
voidpumpkin requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to update edition in more places now after recent merges

@hamza1311
Copy link
Member Author

I believe you need to update edition in more places now after recent merges

Should be fine now.

@voidpumpkin
Copy link
Member

cryptic CI failure. let me restart..

@voidpumpkin voidpumpkin enabled auto-merge (squash) January 12, 2022 14:20
@voidpumpkin voidpumpkin merged commit f05ba41 into yewstack:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madoshakalaka Madoshakalaka Madoshakalaka requested changes

@voidpumpkin voidpumpkin voidpumpkin approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-macro Area: The yew-macro crate A-yew-router Area: The yew-router crate A-yew-router-macro Area: The yew-router-macro crate breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch Edition to 2021
3 participants
@hamza1311 @voidpumpkin @Madoshakalaka