Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BaseComponent Sealed #2359

Merged
merged 1 commit into from Jan 11, 2022
Merged

Make BaseComponent Sealed #2359

merged 1 commit into from Jan 11, 2022

Conversation

futursolo
Copy link
Member

Description

This Pull Request makes BaseComponent "Sealed" hence cannot be implemented directly.
One must choose to implement either Component or #[function_component].

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@voidpumpkin voidpumpkin added the A-yew Area: The main yew crate label Jan 11, 2022
hamza1311
hamza1311 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hamza1311 hamza1311 enabled auto-merge (squash) January 11, 2022 13:01
@hamza1311 hamza1311 merged commit 5dd8b76 into yewstack:master Jan 11, 2022
@futursolo futursolo deleted the sealed-base-component branch January 27, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidpumpkin voidpumpkin voidpumpkin approved these changes

@hamza1311 hamza1311 hamza1311 approved these changes

Assignees
No one assigned
Labels
A-yew Area: The main yew crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@futursolo @voidpumpkin @hamza1311