Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContextHandle in yew::prelude #2372

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Conversation

lameferret
Copy link
Contributor

Description

Adds ContextHandle in yew::prelude

Issue #2358

Added ContextHandle in /yew/src/lib.rs and updated stderr with test-overwrite
@ranile ranile enabled auto-merge (squash) January 15, 2022 17:38
@ranile ranile added the A-yew Area: The main yew crate label Jan 15, 2022
@github-actions
Copy link

github-actions bot commented Jan 15, 2022

Visit the preview URL for this PR (updated for commit b1114b6):

https://yew-rs-api--pr2372-issue-2358-sim33ep8.web.app

(expires Tue, 01 Feb 2022 07:28:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

auto-merge was automatically disabled January 15, 2022 18:08

Head branch was pushed to by a user without write access

Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution, just a one minor problem needs to be fixed.

packages/yew-macro/tests/derive_props/fail.stderr Outdated Show resolved Hide resolved
@voidpumpkin voidpumpkin changed the title Adds ContextHandle in yew::prelude Add ContextHandle in yew::prelude Jan 19, 2022
@voidpumpkin voidpumpkin added the S-waiting-on-author Status: awaiting action from the author of the issue/PR label Jan 22, 2022
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good

@ranile ranile requested a review from voidpumpkin January 25, 2022 11:43
@voidpumpkin voidpumpkin removed the S-waiting-on-author Status: awaiting action from the author of the issue/PR label Jan 25, 2022
@voidpumpkin voidpumpkin merged commit 4580d94 into yewstack:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants