Do not detach child elements if parent element is about to be detached #2420

futursolo · 2022-01-29T01:26:05Z

Description

This pull request aims to minimise the number of DOM API calls when detaching a large number of elements from the DOM tree by only detaching the upper most parent element.

Checklist

I have run cargo make pr-flow (No, pr-flow is broken on macOS #2403)
I have reviewed my own code
I have added tests

… as well.

# Conflicts: # packages/yew-macro/src/hook/body.rs # packages/yew-macro/tests/function_component_attr/hook_location-fail.stderr # packages/yew-macro/tests/function_component_attr/hook_location-pass.rs # packages/yew/src/functional/hooks/mod.rs # packages/yew/src/functional/hooks/use_context.rs # packages/yew/src/functional/hooks/use_effect.rs # packages/yew/src/functional/hooks/use_memo.rs # packages/yew/src/functional/hooks/use_reducer.rs # packages/yew/src/functional/hooks/use_ref.rs # packages/yew/src/functional/hooks/use_state.rs # packages/yew/src/functional/mod.rs # website/docs/migration-guides/yew/from-0_19_0-to-0_20_0.mdx

github-actions · 2022-01-29T01:30:51Z

Visit the preview URL for this PR (updated for commit 461cf38):

https://yew-rs-api--pr2420-no-child-detaching-i-ra93dpum.web.app

_{(expires Sat, 05 Feb 2022 01:30:43 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

WorldSEnder · 2022-01-29T04:08:56Z

Almost the same commit as me in de7df26 (not yet in a PR, so feel free to merge this instead).
I think the only place logic differs from mine is in VSuspense where I think we can get away with pretending the detached_parent always detaches.

ranile

Looks good to me.

Just wondering, when is true passed to detach? I see the false being passed almost everywhere.

futursolo added 30 commits January 12, 2022 23:10

Make a use_hook hook with the new Hook trait.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

c1ed876

Merge branch 'master' into fc-hook-v2

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

863fa92

Implement Lifetime.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

22d91f6

Rewrites function signature.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

d940a7d

Only apply lifetime if there're other lifetimes.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

572becb

Merge branch 'master' into fc-hook-v2

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

7dc8373

Cleanup signature rewrite logic.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

7e8bcdd

Rewrite hook body.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

2664141

Port some built-in hooks.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

aac78b1

Finish porting all built-in hooks.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

1e5c373

Port tests.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

5f086e8

Fix tests.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

a87b2c7

Migrate to macro-based hooks.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

62396f0

Fix HookContext, add tests on non-possible locations.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

72518e2

Fix stderr for trybuild.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

38e06b1

Add 1 more test case.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

19af0b3

Adjust doc location.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

49454cd

Pretty print hook signature.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

eb85f47

Fix Items & std::ops::Fn*.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

4f0260c

Add use_memo.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

344ae10

Optimise Implementation of hooks.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

ffca655

Use Box to capture function value only.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

7b8978b

Detect whether needs boxing.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

15585ff

Merge commit '38021e31fe97202b112c952c6f5fb5b06289fbc5' into fc-hook-v2

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

3dbcdac

Add args if boxing not needed.

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode

f07c648

Enforce hook number.

Unverified

The email in this signature doesn’t match the committer email.

GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode

7118b19

Deduplicate use_effect.

171e085

Optimise Implementation.

2f3856a

Update documentation.

2b1d6f1

Fix website test. Strip BoxedHook implementation from it.

ac765cb

futursolo added 9 commits January 23, 2022 12:17

Allow doc string.

9c300ed

Workaround doc tests.

76da3f6

Optimise codebase & documentation.

541a945

Fix website test.

80dc7e2

Reduce implementation complexity.

347623b

Destructor is no more.

e974dff

Do not detach child element if parent element is about to be detached…

38ef990

… as well.

Fix tests.

461cf38

futursolo mentioned this pull request Jan 29, 2022

Automatic Message Batching #2421

Merged

3 tasks

ranile approved these changes Jan 30, 2022

View reviewed changes

ranile requested review from voidpumpkin and siku2 January 30, 2022 10:52

ranile added A-yew performance labels Jan 30, 2022

voidpumpkin approved these changes Jan 30, 2022

View reviewed changes

voidpumpkin merged commit b7b28ba into yewstack:master Jan 30, 2022

futursolo deleted the no-child-detaching-if-parent-detached branch March 20, 2022 02:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not detach child elements if parent element is about to be detached #2420

Do not detach child elements if parent element is about to be detached #2420

futursolo commented Jan 29, 2022

github-actions bot commented Jan 29, 2022

WorldSEnder commented Jan 29, 2022 •

edited

Loading

ranile left a comment •

edited

Loading

Do not detach child elements if parent element is about to be detached #2420

Do not detach child elements if parent element is about to be detached #2420

Conversation

futursolo commented Jan 29, 2022

Description

Checklist

github-actions bot commented Jan 29, 2022

WorldSEnder commented Jan 29, 2022 • edited Loading

ranile left a comment • edited Loading

Choose a reason for hiding this comment

WorldSEnder commented Jan 29, 2022 •

edited

Loading

ranile left a comment •

edited

Loading